feat: use the Python course as a template for a new JavaScript course #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
added
the
t-academy
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
f4c5ab8 to
ca304ee
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
bc2ff07 to
eb05470
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
e3b6f07 to
6e6db97
Compare
|
Preview for this PR was built for commit |
honzajavorek
added a commit
that referenced
this pull request
Jun 27, 2025
… (groundworks) (#1651) See #1584 for more details. I carved out these two commits so that we can do incremental reviews of my changes in subsequent PRs instead of a huge PR with everything stuffed in it: - 8e6a303 is a copy-paste of the Python course to a new directory called `javascript2` (nothing to review, really) - 9ccf0df makes it `unlisted` There are, of course, more changes to come. This is just groundworks. The `unlisted` trick was recommended by @TC-MO in a [Slack convo](https://pyvec.slack.com/archives/C03BHBQNNG3/p1750773530207319), hopefully ensuring the duplicated course won't be visible on production. Apparently it behaves differently dev vs prod, so I couldn't really verify it properly locally. I tried running `npm run build` hoping I'd get a prod build of the docs, but I only got errors. Using `npm start` I can see the pages in the navigation, but the warning is in place, so I think Docusaurus picks it up correctly: <img width="781" alt="Screenshot 2025-06-27 at 10 37 52" src="https://github.com/user-attachments/assets/7753def0-c08d-47b5-b0c7-96c98541399a" /> Hopefully in the prod build it won't be in the navigation. But in the case it's not gonna work properly on prod, I'm ready to revert this PR immediately.
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
6e6db97 to
104c5cc
Compare
|
Preview for this PR was built for commit |
This was referenced Jun 27, 2025
Merged
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
104c5cc to
82bf3ee
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
honzajavorek
added a commit
that referenced
this pull request
Jun 30, 2025
When working on #1584 I realized it'd be better if the lesson started with JSON and continued with CSV, not the other way. In Python it doesn't matter and in JavaScript it's easier to start with JSON, which is built-in, and only then move to CSV, which requires an additional library. So for the sake of having both lessons aligned, I want to change the order in the Python lesson, too. So most of the diff is just the two sections reversed, and the two exercises reversed. I made only a few additional changes to the wording.
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
d284f74 to
b689317
Compare
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
ee7ae7d to
fa29e5a
Compare
|
Preview for this PR was built for commit |
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
A part of apify#1584 --------- Co-authored-by: gullmar <[email protected]>
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
…ript (apify#1761) Part of apify#1584⚠️ 🐍 Includes a small change also to an exercise in the original `scraping_basics_python` lesson --------- Co-authored-by: gullmar <[email protected]>
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
…ipt (apify#1760) Part of apify#1584, fixes apify#1648⚠️ 🐍 Includes respective changes also to the original `scraping_basics_python` lesson --------- Co-authored-by: Michał Olender <[email protected]>
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
As I progressed with apify#1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered. ----- ℹ️ The changes still use `$.map` and `$.each`, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet.
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
As I progressed with apify#1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered. ----- ℹ️ The changes still use `$.map` and `$.each`, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet.
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
As I progressed with apify#1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered. ----- ℹ️ The changes still use `$.map` and `$.each`, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet.
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
As I progressed with apify#1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered. ----- ℹ️ The changes still use `$.map` and `$.each`, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet. --------- Co-authored-by: gullmar <[email protected]>
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
…ript (apify#1848) Part of apify#1584 ----⚠️ 🐍 This PR contains also changes to the Python course, to keep the lessons consistent and synced. --------- Co-authored-by: Michał Olender <[email protected]>
daveomri
pushed a commit
to daveomri/apify-docs
that referenced
this pull request
Sep 3, 2025
…ut JavaScript (apify#1846) Part of apify#1584 ----⚠️ 🐍 This PR contains also a small change to the Python course, to keep the lessons consistent and synced. --------- Co-authored-by: gullmar <[email protected]>
honzajavorek
added a commit
that referenced
this pull request
Sep 3, 2025
…cript (#1847) Part of #1584 ----⚠️ 🐍 This PR contains also changes to the Python course, to keep the lessons consistent and synced. --------- Co-authored-by: Michał Olender <[email protected]> Co-authored-by: gullmar <[email protected]>
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
9d7c368 to
479a736
Compare
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
479a736 to
5b59e87
Compare
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
5b59e87 to
1ed4660
Compare
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
1ed4660 to
86bb36f
Compare
|
Preview for this PR was built for commit |
honzajavorek
force-pushed
the
honzajavorek/javascript2
branch
from
86bb36f to
2ec727c
Compare
|
Preview for this PR was built for commit |
|
Closing in favor of #1907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept exploring whether using the Python course as a template for a brand new JavaScript course would take less time than trying to improve the original JavaScript course. This work is sanctioned by both @mnmkng and @TC-MO. If viable, this should have the potential to implement #1550 and, of course, deprecate #1579
Done
Challenges
Todo