feat: use the Python course as a template for a new JavaScript course (groundworks) #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview for this PR was built for commit |
|
Ah, cool, I forgot we have the previews now 😄 It works! Only two courses in the navigation:
And it appears if I know the URL:
|
honzajavorek
added
the
t-academy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1584 for more details. I carved out these two commits so that we can do incremental reviews of my changes in subsequent PRs instead of a huge PR with everything stuffed in it:
javascript2(nothing to review, really)unlistedThere are, of course, more changes to come. This is just groundworks.
The
unlistedtrick was recommended by @TC-MO in a Slack convo, hopefully ensuring the duplicated course won't be visible on production. Apparently it behaves differently dev vs prod, so I couldn't really verify it properly locally.I tried running
npm run buildhoping I'd get a prod build of the docs, but I only got errors. Usingnpm startI can see the pages in the navigation, but the warning is in place, so I think Docusaurus picks it up correctly:Hopefully in the prod build it won't be in the navigation. But in the case it's not gonna work properly on prod, I'm ready to revert this PR immediately.