Skip to content

feat: update the platform lesson of the JS2 course to be about JavaScript #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2025
Merged

feat: update the platform lesson of the JS2 course to be about JavaScript #1848

merged 6 commits into from
Sep 3, 2025

Conversation

honzajavorek
Copy link
Collaborator

Part of #1584

⚠️ 🐍 This PR contains also changes to the Python course, to keep the lessons consistent and synced.

@honzajavorek honzajavorek requested review from gullmar and TC-MO August 26, 2025 07:14
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Aug 26, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit f243165 and is ready at https://pr-1848.preview.docs.apify.com!

TC-MO
TC-MO approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, LGTM

@apify-service-account
Copy link

Preview for this PR was built for commit b51bf334 and is ready at https://pr-1848.preview.docs.apify.com!

@honzajavorek honzajavorek force-pushed the honzajavorek/js2-platform branch from b51bf33 to e592f90 Compare September 2, 2025 08:51
@TC-MO
Copy link
Contributor

TC-MO commented Sep 2, 2025

Huh I just realized that unlisted docs are not in the preview 🤔

@honzajavorek
Copy link
Collaborator Author

Comments addressed & rebased. I'll wait for @gullmar to also check the code.

@honzajavorek
Copy link
Collaborator Author

honzajavorek commented Sep 2, 2025 •
edited
Loading

Huh I just realized that unlisted docs are not in the preview 🤔

They are: https://pr-1848.preview.docs.apify.com/academy/scraping-basics-javascript2/platform They're not in the menu though, so to get to that page is a pretty manual process.

@apify-service-account
Copy link

Preview for this PR was built for commit e592f90 and is ready at https://pr-1848.preview.docs.apify.com!

@TC-MO
Copy link
Contributor

TC-MO commented Sep 2, 2025

Yeah yeah I wonder if we could have it like it is on locally run docusaurus where unlisted docs show 🤔 I'll reach out to Tooling team regarding this

@honzajavorek
Copy link
Collaborator Author

@cursor review

@honzajavorek
Copy link
Collaborator Author

Yeah yeah I wonder if we could have it like it is on locally run docusaurus where unlisted docs show 🤔 I'll reach out to Tooling team regarding this

Depends if you want to have the preview closer to what you see locally or as close as possible to what you'll see on production 🤷‍♂️

cursor[bot]
cursor bot reviewed Sep 2, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Comment @cursor review or bugbot run to trigger another review on this PR

gullmar
gullmar approved these changes Sep 3, 2025
View reviewed changes
@apify-service-account
Copy link

Preview for this PR was built for commit 0c6b83e8 and is ready at https://pr-1848.preview.docs.apify.com!

@honzajavorek honzajavorek merged commit 385fbdb into master Sep 3, 2025
9 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-platform branch September 3, 2025 07:58
@apify-service-account
Copy link

Preview for this PR was built for commit d80829aa and is ready at https://pr-1848.preview.docs.apify.com!

daveomri pushed a commit to daveomri/apify-docs that referenced this pull request Sep 3, 2025
@honzajavorek @TC-MO @daveomri
feat: update the platform lesson of the JS2 course to be about JavaSc…
370bfb4 
…ript (apify#1848)

Part of apify#1584

----

⚠️ 🐍 This PR contains also changes to the Python course, to keep the
lessons consistent and synced.

---------

Co-authored-by: Michał Olender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullmar gullmar gullmar approved these changes

@TC-MO TC-MO TC-MO approved these changes

@cursor cursor[bot] cursor[bot] left review comments

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honzajavorek @apify-service-account @TC-MO @gullmar