Skip to content

feat: update the framework lesson of the JS2 course to be about JavaScript #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 3, 2025
Merged

feat: update the framework lesson of the JS2 course to be about JavaScript #1847

merged 10 commits into from
Sep 3, 2025

Conversation

honzajavorek
Copy link
Collaborator

Part of #1584

⚠️ 🐍 This PR contains also changes to the Python course, to keep the lessons consistent and synced.

@honzajavorek honzajavorek requested review from gullmar and TC-MO August 26, 2025 07:08
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Aug 26, 2025
@cursor Cursor
Copy link

cursor bot commented Aug 26, 2025

Bugbot found 2 bugs

To see them, have a team admin activate your membership in the Cursor dashboard.

@apify-service-account
Copy link

Preview for this PR was built for commit f0e4983 and is ready at https://pr-1847.preview.docs.apify.com!

@apify-service-account
Copy link

Preview for this PR was built for commit 449b2919 and is ready at https://pr-1847.preview.docs.apify.com!

TC-MO
TC-MO requested changes Sep 1, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

@honzajavorek honzajavorek force-pushed the honzajavorek/js2-framework branch from 7f7f341 to 8396760 Compare September 2, 2025 09:47
@apify-service-account
Copy link

Preview for this PR was built for commit 8396760 and is ready at https://pr-1847.preview.docs.apify.com!

@honzajavorek
Copy link
Collaborator Author

@cursor review

cursor[bot]
cursor bot reviewed Sep 2, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Comment @cursor review or bugbot run to trigger another review on this PR

@apify-service-account
Copy link

Preview for this PR was built for commit 84b3db9 and is ready at https://pr-1847.preview.docs.apify.com!

@honzajavorek honzajavorek force-pushed the honzajavorek/js2-framework branch from 84b3db9 to 5226084 Compare September 2, 2025 10:02
@apify-service-account
Copy link

Preview for this PR was built for commit 5226084f and is ready at https://pr-1847.preview.docs.apify.com!

@honzajavorek honzajavorek requested a review from TC-MO September 2, 2025 10:06
TC-MO
TC-MO requested changes Sep 2, 2025
View reviewed changes
@honzajavorek honzajavorek requested a review from TC-MO September 2, 2025 11:20
@apify-service-account
Copy link

Preview for this PR was built for commit a1788152 and is ready at https://pr-1847.preview.docs.apify.com!

TC-MO
TC-MO approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion

@apify-service-account
Copy link

Preview for this PR was built for commit ed3488b0 and is ready at https://pr-1847.preview.docs.apify.com!

@honzajavorek
Copy link
Collaborator Author

All done! I think I fixed everything.

cat-dance-dancing-cat-3394750237

I squeezed some review comments about the code out of the Cursor Bugbot, but I'll still wait for @gullmar's eyes before merging, as he had some really good points last time which I believe only humans can have 🤠

gullmar
gullmar approved these changes Sep 3, 2025
View reviewed changes
@apify-service-account
Copy link

Preview for this PR was built for commit 2bb3c6f5 and is ready at https://pr-1847.preview.docs.apify.com!

@honzajavorek honzajavorek merged commit 602b7aa into master Sep 3, 2025
9 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-framework branch September 3, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@gullmar gullmar gullmar approved these changes

@TC-MO TC-MO TC-MO approved these changes

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honzajavorek @apify-service-account @gullmar @TC-MO