Skip to content

feat: update the crawling lesson of the JS2 course to be about JavaScript #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 3, 2025
Merged

feat: update the crawling lesson of the JS2 course to be about JavaScript #1845

merged 4 commits into from
Sep 3, 2025

Conversation

honzajavorek
Copy link
Collaborator

@honzajavorek honzajavorek commented Aug 25, 2025 •
edited
Loading

Part of #1584

⚠️ 🐍 This PR contains also a small change to the Python course, to keep the lessons consistent and synced.

@honzajavorek honzajavorek requested review from gullmar and TC-MO August 25, 2025 19:25
@honzajavorek honzajavorek added the t-academy Issues related to Web Scraping and Apify academies. label Aug 25, 2025
@apify-service-account
Copy link

Preview for this PR was built for commit 409aa6c and is ready at https://pr-1845.preview.docs.apify.com!

@cursor Cursor
Copy link

cursor bot commented Aug 25, 2025

Bugbot found 1 bug

To see it, have a team admin activate your membership in the Cursor dashboard.

TC-MO
TC-MO approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note, otherwise LGTM

@honzajavorek
Copy link
Collaborator Author

I'll wait for @gullmar to check the code before I merge.

@honzajavorek
Copy link
Collaborator Author

@cursor review

cursor[bot]

This comment was marked as outdated.

Sign in to view

@honzajavorek
Copy link
Collaborator Author

@cursor review

@apify-service-account
Copy link

Preview for this PR was built for commit e45a14b1 and is ready at https://pr-1845.preview.docs.apify.com!

cursor[bot]
cursor bot reviewed Sep 2, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Comment @cursor review or bugbot run to trigger another review on this PR

@honzajavorek honzajavorek merged commit 74b78cc into master Sep 3, 2025
10 checks passed
@honzajavorek honzajavorek deleted the honzajavorek/js2-crawling branch September 3, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TC-MO TC-MO TC-MO approved these changes

@cursor cursor[bot] cursor[bot] left review comments

@gullmar gullmar gullmar approved these changes

Assignees
No one assigned
Labels
t-academy Issues related to Web Scraping and Apify academies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@honzajavorek @apify-service-account @gullmar @TC-MO