[fix] properly show error states #5758
Merged
+60
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
🎭 Playwright Test Results⏰ Completed at: 09/24/2025, 08:38:56 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
arjansingh
force-pushed
the
fix/error-states
branch
from
f058337 to
3a9fd98
Compare
DrJKL
requested changes
Sep 24, 2025
Co-authored-by: Alexander Brown <[email protected]>
DrJKL
reviewed
Sep 24, 2025
DrJKL
reviewed
Sep 24, 2025
DrJKL
reviewed
Sep 24, 2025
DrJKL
approved these changes
Sep 24, 2025
|
@DrJKL I'm gonna follow up immediately with the open requested changes in a new pr |
Merged
AustinMroz
pushed a commit
that referenced
this pull request
Sep 25, 2025
## Summary 1. Fixes nits for #5758 2. Adds some git ignores ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5763-Fixes-nits-for-5758-2796d73d36508192b3e6feecfcacf38b) by [Unito](https://www.unito.io) --------- Co-authored-by: filtered <[email protected]>
|
Do we still need the little red outline on the slots with errors or is that already working? |
Still need it |
This was referenced Sep 25, 2025
christian-byrne
added a commit
that referenced
this pull request
Sep 25, 2025
## Summary Added browser test to verify Vue nodes display error state when workflow contains missing/unknown nodes, complementing - #5758 ## Changes - **What**: Added [Playwright test](https://playwright.dev/docs/writing-tests) for Vue nodes error state handling with missing nodes - **Test Coverage**: Validates `border-error` class application on nodes with `UNKNOWN NODE` text ## Review Focus Test reliability when loading workflows with missing nodes and dialog interaction timing. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5768-test-add-browser-test-for-missing-vue-nodes-error-state-2796d73d365081aea187cdbc7920a643) by [Unito](https://www.unito.io)
@christian-byrne Yes we still need those. I didn't fix those because I didn't have enough context on how stuff worked when I fixed this. I probably have enough now to fix that bug. Would you like me to? |
|
@arjansingh Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I want to take a more general look at
comfyApp.graph.onTriggerbut this is the cleanest fix I could come up with for #5694.I will explore simplifying onTrigger in a separate PR.
Changes
node:slot-errors:changedtrigger.Screenshots (if applicable)
Working error states!
┆Issue is synchronized with this Notion page by Unito