Skip to content

Fixes nits for #5758 #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

Fixes nits for #5758 #5763

merged 3 commits into from
Sep 25, 2025

Conversation

arjansingh
Copy link
Contributor

@arjansingh arjansingh commented Sep 25, 2025 •
edited by sync-by-unito bot
Loading

Summary

  1. Fixes nits for [fix] properly show error states #5758
  2. Adds some git ignores

┆Issue is synchronized with this Notion page by Unito

@arjansingh arjansingh requested a review from DrJKL September 25, 2025 00:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/25/2025, 01:26:46 AM UTC

📈 Summary

  • Total Tests: 460
  • Passed: 430 ✅
  • Failed: 0
  • Flaky: 1 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 423 / ❌ 0 / ⚠️ 1 / ⏭️ 29
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

webfiltered
webfiltered requested changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@webfiltered webfiltered left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humbly requesting you take my stuff:

DrJKL
DrJKL previously approved these changes Sep 25, 2025
View reviewed changes
@webfiltered
Remove frankly unreasonable amount of bang-bang (#5764)
da14a5d 
## Summary

Removes a frankly unreasonable amount of bang-bang.

## Changes

- Removes many bang-bang
- Adds one bang-bang to rule them all

## Review Focus

Focus on the bang-bang.

## Screenshots (if applicable)

<img width="20" height="19" alt="image"
src="https://github.com/user-attachments/assets/a33dad3c-351b-49ea-a6fd-d4cf102b0ff9"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5764-Remove-frankly-unreasonable-amount-of-bang-bang-2796d73d365081dc9fafcafd73ba8ff4)
by [Unito](https://www.unito.io)
@DrJKL DrJKL requested a review from webfiltered September 25, 2025 01:10
@AustinMroz AustinMroz merged commit b96bf38 into main Sep 25, 2025
21 checks passed
@AustinMroz AustinMroz deleted the fix/error-state-nits branch September 25, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrJKL DrJKL DrJKL approved these changes

@AustinMroz AustinMroz AustinMroz approved these changes

@webfiltered webfiltered webfiltered approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjansingh @DrJKL @AustinMroz @webfiltered