Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 25, 2025

Summary

Added browser test to verify Vue nodes display error state when workflow contains missing/unknown nodes, complementing

Changes

  • What: Added Playwright test for Vue nodes error state handling with missing nodes
  • Test Coverage: Validates border-error class application on nodes with UNKNOWN NODE text

Review Focus

Test reliability when loading workflows with missing nodes and dialog interaction timing.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 25, 2025
Copy link

github-actions bot commented Sep 25, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/25/2025, 06:14:40 PM UTC

📈 Summary

  • Total Tests: 460
  • Passed: 429 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 422 / ❌ 0 / ⚠️ 2 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link
Contributor

@arjansingh arjansingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could write a component level test for this if you'd like. Will be way more reliable.

@christian-byrne
Copy link
Contributor Author

Sure, sounds good. What do you mean by reliable?

@christian-byrne christian-byrne merged commit a0c06bd into main Sep 25, 2025
33 checks passed
@christian-byrne christian-byrne deleted the vue-nodes/test/error-state branch September 25, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:testing area:vue-migration size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants