test(domain-filter): simple filters on domain exclusion

[ivankatliarchuk]

Description

Relates #3718

The work relates to a bug in domain filter logic. I've added a test that focuses only on MATCH behaviour for a domain filters with include and exclude values, and validate against provided domains. This does not fix anything. The filters itself looks like works correctly.

There is a slight design problem. We instantiate filters in main.go

external-dns/main.go

Line 183 in eb19497

if cfg.RegexDomainFilter.String() != "" {

, this could not be tested, hence the bug could be there. I keep digging.

Probably an option to consider is to create a composition filter or something. Move if/else filter creation logic away from main.go file. Any preferences, ideas?

Checklist

• Unit tests updated
• End user documentation updated

[ivankatliarchuk]

/label tide/merge-method-squash

[mloiseleur]

There are already tests on this with TestDomainFilterWithExclusions on exclusion L408, so I am unsure of what we should do with this PR. Is this still a draft ?

[ivankatliarchuk]

These tests are different. There is some sort of deserialisation, fixtures coupled with two tests, and handled with block like

if len(tt.exclusions) > 0 {
			t.Logf("NewDomainFilter() doesn't support exclusions - skipping test %+v", tt)
			continue
		}

I was actually not able to make it green with such a simple case, probably designed with a slightly different model, that I can't get my head around.

So the plan was to create a simple tests. I think long term this whole domain filter need to be revisited and simplified.

If you think is not required, I'll close this pull request. We could w8 for community member to review they may came out with better plan.

[mloiseleur]

Then let's rename it with a clear different name from the already existing one and we should be good to go.
See my suggestion with a proposition for this name.

[mloiseleur]

/retitle test(domain-filer): simple filters on domain exclusion

[mloiseleur]

/retitle test(domain-filter): simple filters on domain exclusion

[mloiseleur]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment