fix: use informer for istio gateways #4522

woehrl01 · 2024-06-03T09:43:06Z

Description

This PR changes to use an informer instead of direct api calls to read the gateway config. This solves a API ratelimit error on our setup and removes stress on the Kubernetes API

Following this change the tests needed to be updated:

An informer needs a Namespaces, thats why it is set
An informer never returns an error during the get call except for NotExisting. So this test is removed.

Checklist

Unit tests updated
End user documentation updated

k8s-ci-robot · 2024-06-03T09:43:15Z

Hi @woehrl01. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Lukas Wöhrl <[email protected]>

woehrl01 · 2024-06-04T19:39:02Z

/assign szuecs

mloiseleur · 2024-06-11T06:29:13Z

source/istio_virtualservice.go

+	gatewayInformer.Informer().AddEventHandler(
+		cache.ResourceEventHandlerFuncs{
+			AddFunc: func(obj interface{}) {
+				log.Debug("gateway added")
+			},
+		},
+	)


I suggest to either remove this log or provide a more detailed debug log.

Sure, should I also change the other informers? I just replicated the other ones. I suggest removing all of them. Wdyt?

@mloiseleur the eventhandler is needed because of the following behaviour on the go-client: https://github.com/kubernetes/client-go/issues/382, see also the comment above the first informer.

ok, thanks.

mloiseleur · 2024-06-11T06:29:24Z

/ok-to-test

mloiseleur · 2024-06-27T12:19:16Z

/lgtm

woehrl01 · 2024-08-26T16:57:08Z

@mloiseleur do you have any updates on this? It seems like the "approved" label is missing here. Anything I can do about this?

mloiseleur · 2024-08-27T06:21:16Z

A maintainer will review it when he has time for final approval.

The istio provider will move away from the tree, anyway. We have started the process to move the providers out of tree.

woehrl01 · 2024-09-06T05:59:48Z

@mloiseleur Why should Istio support be moved out of tree? It's about discovering DNS entries inside the cluster (its a configurable source). It's not a DNS provider like the list you have linked.

mloiseleur · 2024-09-06T06:37:06Z

Ah yes you're right.

woehrl01 · 2024-11-19T19:26:58Z

Any progress here? It this something which will be considered at all?

mloiseleur · 2024-12-22T18:19:02Z

/unassign @szuecs
/assign @Raffo

woehrl01 · 2025-02-14T14:02:19Z

@Raffo can you please have a look at this PR? Because of this not having fixed, external-dns is by far the most talking service to the api server if you have lots of virtual services. Thank you!

mloiseleur · 2025-02-14T14:07:29Z

@ivanfilippov @Dadeos-Menlo @AndrewCharlesHay Do you think one of you can review this PR ?

Dadeos-Menlo · 2025-02-14T15:43:05Z

/lgtm

k8s-ci-robot · 2025-02-14T15:43:10Z

@Dadeos-Menlo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mloiseleur · 2025-02-14T16:27:34Z

@Dadeos-Menlo In order to lgtm, following official guide, you'll need to Open an issue against the kubernetes/org repo.

mloiseleur · 2025-02-14T16:28:24Z

/approve

k8s-ci-robot · 2025-02-14T16:28:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…o v0.16.1 (#667) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | minor | `v0.15.1` -> `v0.16.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.16.1`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.1) [Compare Source](kubernetes-sigs/external-dns@v0.16.0...v0.16.1) This release fixes the breaking change introduced in v0.16.0 for Cloudflare. :warning: New features on Cloudflare, custom and regional hostnames have some known issues, see [#5175](kubernetes-sigs/external-dns#5175) and [#5183](kubernetes-sigs/external-dns#5183) :warning: OpenStack designate in-tree provider will be removed in the next version. There is now a [webhook provider](https://github.com/inovex/external-dns-openstack-webhook). :information_source: With v0.16.0, a new option on TXT Registry is available to use only new format ([#4946](kubernetes-sigs/external-dns#4946)). Previous format will be removed in the next release ([#5172](kubernetes-sigs/external-dns#5172)). #### 🐛 Bug fixes - fix(cloudflare): optional custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5146 - fix(source): pass GatewayName to config by [@buroa](https://github.com/buroa) in kubernetes-sigs/external-dns#5169 - fix(cloudflare): infinite loop with more than 50 custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5181 #### 📦 Others - chore: update OWNERS with required config file by [@mloiseleur](https://github.com/mloiseleur) in kubernetes-sigs/external-dns#5164 **Full Changelog**: kubernetes-sigs/external-dns@v0.16.0...v0.16.1 ### [`v0.16.0`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.0) [Compare Source](kubernetes-sigs/external-dns@v0.15.1...v0.16.0) #### 💥 Breaking Changes There is a [breaking change on Cloudflare](kubernetes-sigs/external-dns#5166) with this release. It requires Cloudflare for Saas. #### 🚀 Features - feat: add dreamhost webook provider to readme ([#5015](kubernetes-sigs/external-dns#5015)) [@asymingt](https://github.com/asymingt) - feat: Add F5 TransportServer source ([#4944](kubernetes-sigs/external-dns#4944)) [@visokoo](https://github.com/visokoo) - feat(chart): allow to run tpl on `ServiceAccount` annotations ([#4958](kubernetes-sigs/external-dns#4958)) ([#4958](kubernetes-sigs/external-dns#4958)) [@fcrespofastly](https://github.com/fcrespofastly) - feat(cloudflare): custom hostname and fix apex ([#5087](kubernetes-sigs/external-dns#5087)) [@mrozentsvayg](https://github.com/mrozentsvayg) - feat(deps): added renovate config for custom regexes ([#4978](kubernetes-sigs/external-dns#4978)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - feat: don't discard klog logs at the highest log levels (debug and trace) ([#4961](kubernetes-sigs/external-dns#4961)) [@dmarkhas](https://github.com/dmarkhas) - feat(pdns): add validation for MX and SRV records ([#4871](kubernetes-sigs/external-dns#4871)) [@julillae](https://github.com/julillae) - feat(rfc2136): support multiple hosts ([#4653](kubernetes-sigs/external-dns#4653)) [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) - feat(service): listen to endpoint changes ([#5085](kubernetes-sigs/external-dns#5085)) [@dmarkhas](https://github.com/dmarkhas) - feat(source): allow to register all pods and their associated PTR record ([#4782](kubernetes-sigs/external-dns#4782)) [@foyerunix](https://github.com/foyerunix) - feat(txt-registry): add option to use only new format ([#4946](kubernetes-sigs/external-dns#4946)) [@malpou](https://github.com/malpou) #### 🐛 Bug fixes - fix(aes-encryption): support plain txt and url safe base64 strings ([#4980](kubernetes-sigs/external-dns#4980)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(aws-provider): ListTagsForResource incorrect zone-id handling ([#5029](kubernetes-sigs/external-dns#5029)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(chart): non-string types on svcaccount annotations ([#5067](kubernetes-sigs/external-dns#5067)) [@hjoshi123](https://github.com/hjoshi123) - fix(chart): regression with affinity.nodeAffinity getting ignored ([#5046](kubernetes-sigs/external-dns#5046)) [@mkhpalm](https://github.com/mkhpalm) - fix(chart): update rbac for F5 transportserver source ([#5066](kubernetes-sigs/external-dns#5066)) ([#5066](kubernetes-sigs/external-dns#5066)) [@visokoo](https://github.com/visokoo) - fix(cloudflare): add more descriptive log message ([#5047](kubernetes-sigs/external-dns#5047)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - fix(cloudflare): use softerror on internal server error with api ([#4931](kubernetes-sigs/external-dns#4931)) [@vishuvenu](https://github.com/vishuvenu) - fix(dedup): records with different type are not duplicates ([#4889](kubernetes-sigs/external-dns#4889)) [@jtszalay](https://github.com/jtszalay) - fix(docs): aws tutorial broken internal markdown links ([#5036](kubernetes-sigs/external-dns#5036)) [@strophy](https://github.com/strophy) - fix: do not merge CNAME with multiple targets ([#4856](kubernetes-sigs/external-dns#4856)) [@dtuck9](https://github.com/dtuck9) - fix(f5-virtualserver): skip endpoint creation when VirtualServer is not ready ([#4996](kubernetes-sigs/external-dns#4996)) [@mikejoh](https://github.com/mikejoh) - fix(godaddy): Handle missing Retry-After header gracefully ([#4866](kubernetes-sigs/external-dns#4866)) [@alexstojda](https://github.com/alexstojda) - fix(oci): records with multiple IP addresses ([#4993](kubernetes-sigs/external-dns#4993)) [@jrosinsk](https://github.com/jrosinsk) - fix(ovh): cache refresh and duplicates processing ([#4932](kubernetes-sigs/external-dns#4932)) [@nmaupu](https://github.com/nmaupu) - fix(registry): handle empty targets in TXT records logging an error ([#5149](kubernetes-sigs/external-dns#5149)) [@saikatharryc](https://github.com/saikatharryc) - fix(source): allow ipv4-mapped ipv6 addresses ([#4943](kubernetes-sigs/external-dns#4943)) [@buroa](https://github.com/buroa) - fix(source): debug log on gateway target detection ([#5096](kubernetes-sigs/external-dns#5096)) [@drcapulet](https://github.com/drcapulet) - Fix spelling in webhook OpenAPI spec ([#5038](kubernetes-sigs/external-dns#5038)) [@claycooper](https://github.com/claycooper) - fix: use informer for istio gateways ([#4522](kubernetes-sigs/external-dns#4522)) [@woehrl01](https://github.com/woehrl01) #### 📝 Documentation - docs: add deprecation policy ([#5053](kubernetes-sigs/external-dns#5053)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: add staging images to release process ([#5050](kubernetes-sigs/external-dns#5050)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: fix typo on aws tutorial ([#5070](kubernetes-sigs/external-dns#5070)) [@Ileriayo](https://github.com/Ileriayo) - docs: fix typos in tutorials ([#4969](kubernetes-sigs/external-dns#4969)) [@mloiseleur](https://github.com/mloiseleur) - docs(Microsoft DNS): improve instructions ([#4893](kubernetes-sigs/external-dns#4893)) [@TomyLobo](https://github.com/TomyLobo) - docs(proposal): standartise date format ([#5128](kubernetes-sigs/external-dns#5128)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(proposal): update template with statuses ([#5098](kubernetes-sigs/external-dns#5098)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(provider): add ClouDNS to README ([#5065](kubernetes-sigs/external-dns#5065)) [@rwunderer](https://github.com/rwunderer) - docs(README): fix link to dev guide ([#5116](kubernetes-sigs/external-dns#5116)) [@masterkain](https://github.com/masterkain) - docs(registry): fix managed-record-type argument ([#5102](kubernetes-sigs/external-dns#5102)) [@splitice](https://github.com/splitice) - docs: update and refactor contribution part ([#5073](kubernetes-sigs/external-dns#5073)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - ci(docs): add markdown linters and editorconfig ([#5055](kubernetes-sigs/external-dns#5055)) [@mloiseleur](https://github.com/mloiseleur) - Improve sources' docs to mention '--managed-record-types' ([#4882](kubernetes-sigs/external-dns#4882)) [@juan-vg](https://github.com/juan-vg) #### 📦 Others - add: auto label source and providers ([#5158](kubernetes-sigs/external-dns#5158)) [@szuecs](https://github.com/szuecs) - Add OpenStack Designate webook provider to readme ([#5115](kubernetes-sigs/external-dns#5115)) [@frittentheke](https://github.com/frittentheke) - chore(ci): fix and sort changelog ([#4979](kubernetes-sigs/external-dns#4979)) [@mloiseleur](https://github.com/mloiseleur) dependabot - chore(ci): fix failing test, upgrade to go 1.23.5 and linter to v1.63 ([#5013](kubernetes-sigs/external-dns#5013)) [@mloiseleur](https://github.com/mloiseleur) - chore(ci): remove too slow test ([#5014](kubernetes-sigs/external-dns#5014)) [@mloiseleur](https://github.com/mloiseleur) - chore(deps): bump actions/setup-python from 5.3.0 to 5.4.0 in the dev-dependencies group ([#5041](kubernetes-sigs/external-dns#5041)) [@dependabot](https://github.com/dependabot) - chore(deps): bump azure/setup-helm from 4.2.0 to 4.3.0 in the dev-dependencies group ([#5108](kubernetes-sigs/external-dns#5108)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.10.0 to 1.11.0 in the dev-dependencies group ([#4956](kubernetes-sigs/external-dns#4956)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 in the dev-dependencies group ([#4972](kubernetes-sigs/external-dns#4972)) [@dependabot](https://github.com/dependabot) - chore(deps): bump nosborn/github-action-markdown-cli from 3.3.0 to 3.4.0 in the dev-dependencies group ([#5083](kubernetes-sigs/external-dns#5083)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 14 updates ([#4976](kubernetes-sigs/external-dns#4976)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 18 updates ([#5040](kubernetes-sigs/external-dns#5040)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 20 updates ([#4999](kubernetes-sigs/external-dns#4999)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 21 updates ([#5089](kubernetes-sigs/external-dns#5089)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 22 updates ([#5062](kubernetes-sigs/external-dns#5062)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 23 updates ([#5145](kubernetes-sigs/external-dns#5145)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 25 updates ([#5023](kubernetes-sigs/external-dns#5023)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 5 updates ([#4987](kubernetes-sigs/external-dns#4987)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 7 updates ([#5125](kubernetes-sigs/external-dns#5125)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 20 updates ([#5109](kubernetes-sigs/external-dns#5109)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 2 updates ([#5022](kubernetes-sigs/external-dns#5022)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 3 updates ([#5112](kubernetes-sigs/external-dns#5112)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 4 updates ([#4988](kubernetes-sigs/external-dns#4988)) [@dependabot](https://github.com/dependabot) - chore(docs): docs/flags.md generation ([#4983](kubernetes-sigs/external-dns#4983)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(filter-tags): pre-process filter tags ([#5063](kubernetes-sigs/external-dns#5063)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): add helper and document targets ([#5093](kubernetes-sigs/external-dns#5093)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): simplify coverage script ([#5105](kubernetes-sigs/external-dns#5105)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(provider-aws): improve canonicalHostedZone handling ([#5031](kubernetes-sigs/external-dns#5031)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(release): publish chart v1.15.2 ([#5094](kubernetes-sigs/external-dns#5094)) [@stevehipwell](https://github.com/stevehipwell) - chore: update maintainers/reviewers ([#5020](kubernetes-sigs/external-dns#5020)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore: upgrade ExternalDNS to go 1.24 ([#5106](kubernetes-sigs/external-dns#5106)) [@mloiseleur](https://github.com/mloiseleur) - kustomize-v0.15.1 ([#4966](kubernetes-sigs/external-dns#4966)) [@Raffo](https://github.com/Raffo) - Release Helm chart for `v0.15.1` ([#5028](kubernetes-sigs/external-dns#5028)) [@stevehipwell](https://github.com/stevehipwell) - replace all versions to v0.15.1 ([#4973](kubernetes-sigs/external-dns#4973)) [@Raffo](https://github.com/Raffo) - test(cloudflare): add scenarios on submitChanges ([#5054](kubernetes-sigs/external-dns#5054)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - test(domain-filter): simple filters on domain exclusion ([#5064](kubernetes-sigs/external-dns#5064)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - test(provider): tags filter coverage and benchmark ([#5060](kubernetes-sigs/external-dns#5060)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) #### New Contributors - [@juan-vg](https://github.com/juan-vg) made their first contribution in kubernetes-sigs/external-dns#4882 - [@dmarkhas](https://github.com/dmarkhas) made their first contribution in kubernetes-sigs/external-dns#4961 - [@buroa](https://github.com/buroa) made their first contribution in kubernetes-sigs/external-dns#4943 - [@fcrespofastly](https://github.com/fcrespofastly) made their first contribution in kubernetes-sigs/external-dns#4958 - [@nmaupu](https://github.com/nmaupu) made their first contribution in kubernetes-sigs/external-dns#4932 - [@dtuck9](https://github.com/dtuck9) made their first contribution in kubernetes-sigs/external-dns#4856 - [@asymingt](https://github.com/asymingt) made their first contribution in kubernetes-sigs/external-dns#5015 - [@alexstojda](https://github.com/alexstojda) made their first contribution in kubernetes-sigs/external-dns#4866 - [@visokoo](https://github.com/visokoo) made their first contribution in kubernetes-sigs/external-dns#4944 - [@vishuvenu](https://github.com/vishuvenu) made their first contribution in kubernetes-sigs/external-dns#4931 - [@TomyLobo](https://github.com/TomyLobo) made their first contribution in kubernetes-sigs/external-dns#4893 - [@strophy](https://github.com/strophy) made their first contribution in kubernetes-sigs/external-dns#5036 - [@malpou](https://github.com/malpou) made their first contribution in kubernetes-sigs/external-dns#4946 - [@foyerunix](https://github.com/foyerunix) made their first contribution in kubernetes-sigs/external-dns#4782 - [@rwunderer](https://github.com/rwunderer) made their first contribution in kubernetes-sigs/external-dns#5065 - [@Ileriayo](https://github.com/Ileriayo) made their first contribution in kubernetes-sigs/external-dns#5070 - [@hjoshi123](https://github.com/hjoshi123) made their first contribution in kubernetes-sigs/external-dns#5067 - [@mkhpalm](https://github.com/mkhpalm) made their first contribution in kubernetes-sigs/external-dns#5046 - [@woehrl01](https://github.com/woehrl01) made their first contribution in kubernetes-sigs/external-dns#4522 - [@jtszalay](https://github.com/jtszalay) made their first contribution in kubernetes-sigs/external-dns#4889 - [@splitice](https://github.com/splitice) made their first contribution in kubernetes-sigs/external-dns#5102 - [@drcapulet](https://github.com/drcapulet) made their first contribution in kubernetes-sigs/external-dns#5096 - [@mrozentsvayg](https://github.com/mrozentsvayg) made their first contribution in kubernetes-sigs/external-dns#5087 - [@frittentheke](https://github.com/frittentheke) made their first contribution in kubernetes-sigs/external-dns#5115 - [@masterkain](https://github.com/masterkain) made their first contribution in kubernetes-sigs/external-dns#5116 - [@renanqts](https://github.com/renanqts) made their first contribution in kubernetes-sigs/external-dns#5132 - [@rlees85](https://github.com/rlees85) made their first contribution in kubernetes-sigs/external-dns#5111 - [@stefaneg](https://github.com/stefaneg) made their first contribution in kubernetes-sigs/external-dns#5135 - [@saikatharryc](https://github.com/saikatharryc) made their first contribution in kubernetes-sigs/external-dns#5149 **Full Changelog**: kubernetes-sigs/external-dns@v0.15.1...v0.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/667 Co-authored-by: JesusMtnez-bot <[email protected]> Co-committed-by: JesusMtnez-bot <[email protected]>

k8s-ci-robot requested review from johngmyers and szuecs June 3, 2024 09:43

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2024

woehrl01 force-pushed the informer-gateways branch from d477f90 to b5f145f Compare June 3, 2024 09:43

fix: use informer for istio gateways

25eac69

Signed-off-by: Lukas Wöhrl <[email protected]>

woehrl01 force-pushed the informer-gateways branch from b5f145f to 25eac69 Compare June 3, 2024 09:44

k8s-ci-robot assigned szuecs Jun 4, 2024

mloiseleur reviewed Jun 11, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2024

k8s-ci-robot assigned mloiseleur Jun 27, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024

k8s-ci-robot assigned Raffo and unassigned szuecs Dec 22, 2024

mloiseleur removed their assignment Dec 22, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025

k8s-ci-robot merged commit ba98af8 into kubernetes-sigs:master Feb 14, 2025
4 checks passed

fix: use informer for istio gateways #4522

fix: use informer for istio gateways #4522

Uh oh!

Conversation

woehrl01 commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 3, 2024

Uh oh!

woehrl01 commented Jun 4, 2024

Uh oh!

mloiseleur Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

woehrl01 Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

woehrl01 Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

mloiseleur Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

mloiseleur commented Jun 11, 2024

Uh oh!

mloiseleur commented Jun 27, 2024

Uh oh!

woehrl01 commented Aug 26, 2024

Uh oh!

mloiseleur commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

woehrl01 commented Sep 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mloiseleur commented Sep 6, 2024

Uh oh!

woehrl01 commented Nov 19, 2024

Uh oh!

mloiseleur commented Dec 22, 2024

Uh oh!

woehrl01 commented Feb 14, 2025

Uh oh!

mloiseleur commented Feb 14, 2025

Uh oh!

Dadeos-Menlo commented Feb 14, 2025

Uh oh!

k8s-ci-robot commented Feb 14, 2025

Uh oh!

mloiseleur commented Feb 14, 2025

Uh oh!

mloiseleur commented Feb 14, 2025

Uh oh!

k8s-ci-robot commented Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

woehrl01 commented Jun 3, 2024 •

edited

Loading

mloiseleur commented Aug 27, 2024 •

edited

Loading

woehrl01 commented Sep 6, 2024 •

edited

Loading