fix(aes-encryption): support plain txt and url safe base64 strings

[ivankatliarchuk]

Description

Fixes #4975
Fixes #3992

The primary change in behavior is that the service will now successfully start when an AES key is provided as outlined in the documentation (text or base64 form). The core business logic related to encryption remains unchanged.

• added tests to cover missing branches for endpoint.{labels,crypto}
• added tests to cover logic when AES keys is base64 form
• added tests to cover current label encryption logic for records
• updated/rephrased documentation

While was working on a fix, found a bug, where Dynamodb not encrypting labels

external-dns/registry/dynamodb.go

Line 239 in e964a66

statements = im.appendInsert(statements, key, r.Labels)

Trying to keep the scope of this pull request small. And could tweak DynamoDB encryption in follow up if required.

When TXT registry behaves correctly

external-dns/registry/txt.go

Line 270 in e964a66

filteredChanges.Delete = append(filteredChanges.Delete, im.generateTXTRecord(r)...)

Look's like the feature is not in use as was not able to find a single issue to date

Added tests

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @ivankatliarchuk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/ok-to-test

[mloiseleur]

A related issue is declared in #3992
There was also a PR, but it did not manage to get merged, see #4063

If I follow correctly this PR, there is no migration needed, not like with #4063.

/lgtm
/assign @Raffo

[ivankatliarchuk]

I'm blind. Could just refresh a PR 😄😄😄. But at least now I'm a bit familiar with the code behind it

[mloiseleur]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baurmatt]

@ivankatliarchuk Any chance to get this released? :) I really like to use the encryption feature!

[ivankatliarchuk]

Well the fix is in master, you could try latest official staging image https://console.cloud.google.com/gcr/images/k8s-staging-external-dns/GLOBAL/external-dns?pli=1&inv=1&invt=AboH_A

Since I am not the owner or maintainer of this repository, I cannot give you a release timeline.