Skip to content

Rename ConvertFToTF32INTEL to RoundFToTF32INTEL #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2023
Merged

Rename ConvertFToTF32INTEL to RoundFToTF32INTEL #1913

merged 2 commits into from
Mar 28, 2023

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Mar 28, 2023 •
edited
Loading

Extension name will be preserved for a while for binary compatibility.

There is not public spec change yet, but it has to be done ASAP

@MrSidims
Rename SPV_INTEL_tensor_float32_conversion
5675d2e 
To SPV_INTEL_tensor_float32_rounding

Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims
Copy link
Contributor Author

@asudarsa @vmaksimo @jgstarIntel @maksimsab please take a look

vmaksimo
vmaksimo approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@vmaksimo vmaksimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Guess it won't hurt anyone except if there are some changes required in other SPIRV consumers

@MrSidims
Restore extension name
09bdc8d 
Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims changed the title Rename SPV_INTEL_tensor_float32_conversion Rename ConvertFToTF32INTEL to RoundFToTF32INTEL Mar 28, 2023
@MrSidims MrSidims merged commit 68855f6 into KhronosGroup:main Mar 28, 2023
@MrSidims MrSidims mentioned this pull request Mar 28, 2023
Closed
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
0d29c46 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
e7fa7a5 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
ec54b95 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
36b9c97 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
bb13f3a 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
f9176f7 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
a475cbd 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
551cc87 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
437ed4e 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 2, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
5a9bda1 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
f094716 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
118ac64 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
3ffaa69 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
4543c5f 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
abbc293 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
9b0af5b 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
b8fb238 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
MrSidims added a commit to MrSidims/SPIRV-LLVM-Translator that referenced this pull request Apr 3, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
ecdeaf1 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
@MrSidims MrSidims mentioned this pull request Apr 4, 2023
Merged
MrSidims added a commit that referenced this pull request Apr 4, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (#1913) (#1937)
5431831 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
This was referenced Apr 4, 2023
Merged
Merged
Merged
MrSidims added a commit that referenced this pull request Apr 4, 2023
@MrSidims
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (#1913) (#1940)
828bdeb 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
This was referenced Apr 4, 2023
Merged
Merged
Merged
Merged
fda0 pushed a commit to fda0/SPIRV-LLVM-Translator that referenced this pull request May 22, 2025
@MrSidims @fda0
[Backport to 16] Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (Khr…
7a457b6 
…onosGroup#1913)

Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
(cherry picked from commit 68855f6)
bokrzesi pushed a commit to bokrzesi/SPIRV-LLVM-Translator that referenced this pull request Jun 10, 2025
@MrSidims @bokrzesi
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
a460488 
Extension name will be preserved for a while for binary compatibility.

Signed-off-by: Sidorov, Dmitry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaksimo vmaksimo vmaksimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrSidims @vmaksimo