Skip to content

Commit 9b0af5b

Browse files
committed
Rename ConvertFToTF32INTEL to RoundFToTF32INTEL (KhronosGroup#1913)
Extension name will be preserved for a while for binary compatibility. Signed-off-by: Sidorov, Dmitry <[email protected]>
1 parent a1cecd6 commit 9b0af5b

File tree

6 files changed

+27
-26
lines changed

6 files changed

+27
-26
lines changed

include/LLVMSPIRVExtensions.inc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ EXT(SPV_INTEL_memory_access_aliasing)
3333
EXT(SPV_INTEL_debug_module)
3434
EXT(SPV_INTEL_bfloat16_conversion)
3535
EXT(SPV_INTEL_masked_gather_scatter)
36-
EXT(SPV_INTEL_tensor_float32_conversion)
36+
EXT(SPV_INTEL_tensor_float32_conversion) // TODO: to remove old extension
37+
EXT(SPV_INTEL_tensor_float32_rounding)
3738
EXT(SPV_EXT_relaxed_printf_string_address_space)
3839
EXT(SPV_INTEL_hw_thread_queries)
3940
EXT(SPV_INTEL_split_barrier)

lib/SPIRV/libSPIRV/SPIRVInstruction.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3404,10 +3404,10 @@ _SPIRV_OP(MaskedScatter, false, 5)
34043404
#undef _SPIRV_OP
34053405

34063406
template <Op OC>
3407-
class SPIRVTensorFloat32ConversionINTELInstBase : public SPIRVUnaryInst<OC> {
3407+
class SPIRVTensorFloat32RoundingINTELInstBase : public SPIRVUnaryInst<OC> {
34083408
protected:
34093409
SPIRVCapVec getRequiredCapability() const override {
3410-
return getVec(internal::CapabilityTensorFloat32ConversionINTEL);
3410+
return getVec(internal::CapabilityTensorFloat32RoundingINTEL);
34113411
}
34123412

34133413
SPIRVExtSet getRequiredExtensions() const override {
@@ -3428,8 +3428,8 @@ class SPIRVTensorFloat32ConversionINTELInstBase : public SPIRVUnaryInst<OC> {
34283428
// because it may call a method of class Module that may modify LiteralMap
34293429
// of Module field. That modification is not impacting validate method for
34303430
// these instructions, so const_cast is safe here.
3431-
using SPVTF32ConvTy = SPIRVTensorFloat32ConversionINTELInstBase<OC>;
3432-
SPIRVValue *Input = const_cast<SPVTF32ConvTy *>(this)->getOperand(0);
3431+
using SPVTF32RoundTy = SPIRVTensorFloat32RoundingINTELInstBase<OC>;
3432+
SPIRVValue *Input = const_cast<SPVTF32RoundTy *>(this)->getOperand(0);
34333433

34343434
SPIRVType *InCompTy = Input->getType();
34353435
SPIRVWord InCompCount = 1;
@@ -3457,8 +3457,8 @@ class SPIRVTensorFloat32ConversionINTELInstBase : public SPIRVUnaryInst<OC> {
34573457
};
34583458

34593459
#define _SPIRV_OP(x) \
3460-
typedef SPIRVTensorFloat32ConversionINTELInstBase<internal::Op##x> SPIRV##x;
3461-
_SPIRV_OP(ConvertFToTF32INTEL)
3460+
typedef SPIRVTensorFloat32RoundingINTELInstBase<internal::Op##x> SPIRV##x;
3461+
_SPIRV_OP(RoundFToTF32INTEL)
34623462
#undef _SPIRV_OP
34633463

34643464
class SPIRVSplitBarrierINTELBase : public SPIRVInstTemplateBase {

lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -585,8 +585,8 @@ template <> inline void SPIRVMap<Capability, std::string>::init() {
585585
add(internal::CapabilityDebugInfoModuleINTEL, "DebugInfoModuleINTEL");
586586
add(internal::CapabilityBfloat16ConversionINTEL, "Bfloat16ConversionINTEL");
587587
add(internal::CapabilityMaskedGatherScatterINTEL, "MaskedGatherScatterINTEL");
588-
add(internal::CapabilityTensorFloat32ConversionINTEL,
589-
"TensorFloat32ConversionINTEL");
588+
add(internal::CapabilityTensorFloat32RoundingINTEL,
589+
"TensorFloat32RoundingINTEL");
590590
add(internal::CapabilityHWThreadQueryINTEL, "HWThreadQueryINTEL");
591591
add(CapabilitySplitBarrierINTEL, "SplitBarrierINTEL");
592592
add(internal::CapabilityGlobalVariableDecorationsINTEL,

lib/SPIRV/libSPIRV/SPIRVOpCodeEnumInternal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ _SPIRV_OP_INTERNAL(ConvertFToBF16INTEL, internal::OpConvertFToBF16INTEL)
88
_SPIRV_OP_INTERNAL(ConvertBF16ToFINTEL, internal::OpConvertBF16ToFINTEL)
99
_SPIRV_OP_INTERNAL(MaskedGatherINTEL, internal::OpMaskedGatherINTEL)
1010
_SPIRV_OP_INTERNAL(MaskedScatterINTEL, internal::OpMaskedScatterINTEL)
11-
_SPIRV_OP_INTERNAL(ConvertFToTF32INTEL, internal::ConvertFToTF32INTEL)
11+
_SPIRV_OP_INTERNAL(RoundFToTF32INTEL, internal::RoundFToTF32INTEL)

lib/SPIRV/libSPIRV/spirv_internal.hpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ enum InternalOp {
4040
IOpAliasScopeListDeclINTEL = 5913,
4141
IOpConvertFToBF16INTEL = 6116,
4242
IOpConvertBF16ToFINTEL = 6117,
43-
IOpConvertFToTF32INTEL = 6426,
43+
IOpRoundFToTF32INTEL = 6426,
4444
IOpMaskedGatherINTEL = 6428,
4545
IOpMaskedScatterINTEL = 6429,
4646
IOpPrev = OpMax - 2,
@@ -59,7 +59,7 @@ enum InternalCapability {
5959
ICapMemoryAccessAliasingINTEL = 5910,
6060
ICapDebugInfoModuleINTEL = 6114,
6161
ICapBfloat16ConversionINTEL = 6115,
62-
ICapabilityTensorFloat32ConversionINTEL = 6425,
62+
ICapabilityTensorFloat32RoundingINTEL = 6425,
6363
ICapabilityMaskedGatherScatterINTEL = 6427,
6464
ICapabilityHWThreadQueryINTEL = 6134,
6565
ICapGlobalVariableDecorationsINTEL = 6146
@@ -78,8 +78,8 @@ _SPIRV_OP(Capability, MaskedGatherScatterINTEL)
7878
_SPIRV_OP(Op, MaskedGatherINTEL)
7979
_SPIRV_OP(Op, MaskedScatterINTEL)
8080

81-
_SPIRV_OP(Capability, TensorFloat32ConversionINTEL)
82-
_SPIRV_OP(Op, ConvertFToTF32INTEL)
81+
_SPIRV_OP(Capability, TensorFloat32RoundingINTEL)
82+
_SPIRV_OP(Op, RoundFToTF32INTEL)
8383

8484
enum InternalBuiltIn {
8585
IBuiltInSubDeviceIDINTEL = 6135,

test/transcoding/SPV_INTEL_tensor_float32_conversion/convert_tensor_float32.ll

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-n8:16:32:64"
1414
target triple = "spir64-unknown-unknown"
1515

16-
; CHECK-SPIRV: Capability TensorFloat32ConversionINTEL
16+
; CHECK-SPIRV: Capability TensorFloat32RoundingINTEL
1717
; CHECK-SPIRV: Extension "SPV_INTEL_tensor_float32_conversion"
1818
; CHECK-SPIRV: TypeFloat [[#FP32Ty:]] 32
1919
; CHECK-SPIRV: TypeVector [[#FP32v8Ty:]] [[#FP32Ty]] 8
@@ -22,24 +22,24 @@ target triple = "spir64-unknown-unknown"
2222
; CHECK-SPIRV: FunctionParameter [[#FP32Ty]] [[FP32ValId:.*]]
2323
; CHECK-SPIRV: FunctionParameter [[#FP32v8Ty]] [[FP32v8ValId:.*]]
2424

25-
; CHECK-SPIRV: ConvertFToTF32INTEL [[#FP32Ty]] [[#]] [[FP32ValId]]
26-
; CHECK-SPIRV: ConvertFToTF32INTEL [[#FP32v8Ty]] [[#]] [[FP32v8ValId]]
27-
; CHECK-SPIRV: ConvertFToTF32INTEL [[#FP32Ty]] [[#]] [[#CONST]]
25+
; CHECK-SPIRV: RoundFToTF32INTEL [[#FP32Ty]] [[#]] [[FP32ValId]]
26+
; CHECK-SPIRV: RoundFToTF32INTEL [[#FP32v8Ty]] [[#]] [[FP32v8ValId]]
27+
; CHECK-SPIRV: RoundFToTF32INTEL [[#FP32Ty]] [[#]] [[#CONST]]
2828

29-
; CHECK-LLVM: call spir_func float @_Z27__spirv_ConvertFToTF32INTELf(float
30-
; CHECK-LLVM: call spir_func <8 x float> @_Z27__spirv_ConvertFToTF32INTELDv8_f(<8 x float>
31-
; CHECK-LLVM: call spir_func float @_Z27__spirv_ConvertFToTF32INTELf(float 1.000000e+00)
29+
; CHECK-LLVM: call spir_func float @_Z25__spirv_RoundFToTF32INTELf(float
30+
; CHECK-LLVM: call spir_func <8 x float> @_Z25__spirv_RoundFToTF32INTELDv8_f(<8 x float>
31+
; CHECK-LLVM: call spir_func float @_Z25__spirv_RoundFToTF32INTELf(float 1.000000e+00)
3232

3333
define spir_func void @_Z2opffv8(float %a, <8 x float> %in) {
34-
%1 = tail call spir_func float @_Z27__spirv_ConvertFToTF32INTELf(float %a)
35-
%2 = tail call spir_func <8 x float> @_Z27__spirv_ConvertFToTF32INTELDv8_f(<8 x float> %in)
36-
%3 = tail call spir_func float @_Z27__spirv_ConvertFToTF32INTELf(float 1.000000e+00)
34+
%1 = tail call spir_func float @_Z25__spirv_RoundFToTF32INTELf(float %a)
35+
%2 = tail call spir_func <8 x float> @_Z25__spirv_RoundFToTF32INTELDv8_f(<8 x float> %in)
36+
%3 = tail call spir_func float @_Z25__spirv_RoundFToTF32INTELf(float 1.000000e+00)
3737
ret void
3838
}
3939

40-
declare spir_func float @_Z27__spirv_ConvertFToTF32INTELf(float)
40+
declare spir_func float @_Z25__spirv_RoundFToTF32INTELf(float)
4141

42-
declare spir_func <8 x float> @_Z27__spirv_ConvertFToTF32INTELDv8_f(<8 x float>)
42+
declare spir_func <8 x float> @_Z25__spirv_RoundFToTF32INTELDv8_f(<8 x float>)
4343

4444
!opencl.spir.version = !{!0}
4545
!spirv.Source = !{!1}

0 commit comments

Comments
 (0)