Fix client use i pv6 address with default port, host was not properly wrapped by [], java servlet parsing header host will report an error #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix client ipv6 bug
add test
|
@lifw555 thanks for the pull request. Could you please take a look at broken unit tests? |
fix ipv6 bug
yhirose
reviewed
Sep 12, 2025
yhirose
reviewed
Sep 12, 2025
yhirose
reviewed
Sep 12, 2025
|
@lifw555 I added comments. Those tests shouldn't be changed, since cpp-httplib accepts IPv6 addresses that are not fully qualified. (https://en.wikipedia.org/wiki/IPv6_address) So could you please revert the changes and update httplib.h so that all the existing tests pass as they are? (In other words, the current change in httplib.h isn't sufficient and introduces a breaking change that may cause problems for existing users' code.) |
|
sorry，I will restore the code I modified back to its original state。 |
…P and port. When using the default port (not passed by default), if there is no [] distinction, Java will use the last colon of IPv6 as the port delimiter, and Java parsing will report an error
lifw555
changed the title
|
This fixed should be correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.