client use ipv6 error

[lifw555]

inline Client::Client(const std::string &scheme_host_port,
                      const std::string &client_cert_path,
                      const std::string &client_key_path) {
.......

    auto host = m[2].str();
    if (host.empty()) { host = m[3].str(); }

.......

If the client initiates an IPv6 request, the IPv6 address in the host field of the request header is not used [], which can cause the server to receive an error in parsing the request header.

Add the following code to fix this bug

inline Client::Client(const std::string &scheme_host_port,
                      const std::string &client_cert_path,
                      const std::string &client_key_path) {
.......

    auto host = m[2].str();
    if (host.empty()) { host = m[3].str(); }
    if (host.find(':') != std::string::npos) { host = "[" + host + "]"; }   // this code 
.......

Hope it's useful

[yhirose]

@lifw555 could you please send a pull request and a unit test in test/test.cc? Thanks!

[lifw555]

When I tracked the code and found the core location where the problem occurred, I found that the core issue was that the IPV6 host was not properly wrapped by [] when the port was the default port (80 or 443).

Code Location

inline ClientImpl::ClientImpl(const std::string &host, int port,
                              const std::string &client_cert_path,
                              const std::string &client_key_path)
    : host_(detail::escape_abstract_namespace_unix_domain(host)), port_(port),
      host_and_port_(adjust_host_string(host_) + ":" + std::to_string(port)),
      client_cert_path_(client_cert_path), client_key_path_(client_key_path) {}

the following code to fix this bug

inline ClientImpl::ClientImpl(const std::string &host, int port,
                              const std::string &client_cert_path,
                              const std::string &client_key_path)
    : host_(adjust_host_string(detail::escape_abstract_namespace_unix_domain(host))), port_(port),
      host_and_port_(host_ + ":" + std::to_string(port)),
      client_cert_path_(client_cert_path), client_key_path_(client_key_path) {}

I will attempt to submit a pull request.

thanks

[lifw555]

add pull reqest at 2237