[ASTGen] Update for specialized attribute kind removal #80351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
CodaFi,
ahoppen,
bnbarham and
hamishknight
as code owners
|
swiftlang/swift-syntax#3028 |
rintaro
force-pushed
the
astgen-attributes-reorg
branch
from
5d0fa4e to
02f2676
Compare
In `SwiftSyntax`, some cases in `AttributeSyntax.Arguments` enum are being consolidated to `.argumentList(LabeledExprListSyntax)`
rintaro
force-pushed
the
astgen-attributes-reorg
branch
from
02f2676 to
2a21e68
Compare
|
swiftlang/swift-syntax#3028 |
This was referenced Mar 27, 2025
Merged
|
swiftlang/swift-format#971 |
rintaro
changed the title
|
swiftlang/swift-format#971 |
hamishknight
approved these changes
Mar 31, 2025
| let arg = node.arguments?.as(TokenSyntax.self) | ||
| else { | ||
| print("Not a token") | ||
| // TODO: Diagnose. |
There was a problem hiding this comment.
Should this comment be preserved? Here and all the case below
There was a problem hiding this comment.
generateWithLabeledExprListArguments and generateConsuming* will diagnose if the input is unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for swiftlang/swift-syntax#3028
In
SwiftSyntax, some cases inAttributeSyntax.Argumentsenum are being consolidated to.argumentList(LabeledExprListSyntax)