Skip to content

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 28, 2025

Some specialized AttributeSyntax.Arguments cases and related types are being removed from swift-syntax.

Some specialized `AttributeSyntax.Arguments` cases and related types are
being removed from swift-syntax.
@allevato
Copy link
Member

Is that the only place in TokenStreamCreator that's actually affected? I thought we covered more of the attributes you mentioned. Maybe it's not as big a savings as I thought it would be. 🙁 (We should still do it though.)

We have a little bit of a chicken-and-egg problem here since the tests will fail unless this is built against a version of swift-syntax that has the parser changes to produce argument lists instead of the old nodes. Do we support paired repos in the new PR testing workflow?

@rintaro
Copy link
Member Author

rintaro commented Mar 28, 2025

@rintaro
Copy link
Member Author

rintaro commented Mar 28, 2025

Ah no @swift-ci PR testing anymore? But at least we can test it from swift-syntax repo
swiftlang/swift-syntax#3028 (comment)

@rintaro
Copy link
Member Author

rintaro commented Mar 28, 2025

Is that the only place in TokenStreamCreator that's actually affected? I thought we covered more of the attributes you mentioned.

As far as I tested locally 🙂 Many are underscored attributes, no wonder they weren't handled.

@ahoppen
Copy link
Member

ahoppen commented Mar 28, 2025

Let me try and push for a review on swiftlang/github-workflows#52 and allow cross-PR testing for GitHub actions. In the meantime, we’ll have to find someone with force merge capabilities to merge this.

@bnbarham
Copy link
Contributor

Merging despite failures as we have no way to run cross-PR testing here yet.

@bnbarham bnbarham merged commit 3578807 into swiftlang:main Mar 31, 2025
9 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants