Skip to content

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Sep 25, 2025

This reverts #1299 after fixing the Windows build in 764d363.

…en DocC and external link resolver executables (#1292)" (#1299)"

257c62d
@d-ronnqvist
Copy link
Contributor Author

This is waiting on the Windows toolchain build in swiftlang/swift#84510 to pass before merging.

@d-ronnqvist d-ronnqvist marked this pull request as draft September 25, 2025 12:58
@d-ronnqvist
Copy link
Contributor Author

I think that this resolves the issue but I would like someone to double check and answer my question about the toolchain build in this comment.

Copy link
Contributor

@anferbui anferbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once we've confirmed the toolchain builds successfully with these changes

@d-ronnqvist
Copy link
Contributor Author

I confirmed that the same issue happens with main, so we should be good to merge this PR.

@d-ronnqvist d-ronnqvist marked this pull request as ready for review September 26, 2025 12:56
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 163fd03 into main Sep 26, 2025
2 checks passed
@d-ronnqvist d-ronnqvist deleted the revert-1299 branch September 26, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants