Skip to content

services/progress: Add missing didCancel() check #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021
Merged

services/progress: Add missing didCancel() check #3159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/services/progress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { tracked } from '@glimmer/tracking';
import Ember from 'ember';

import * as Sentry from '@sentry/browser';
import { rawTimeout, task } from 'ember-concurrency';
import { didCancel, rawTimeout, task } from 'ember-concurrency';

const SPEED = 200;

Expand All @@ -26,8 +26,10 @@ export default class ProgressService extends Service {

@task(function* (promise) {
this.updateTask.perform().catch(error => {
// this task shouldn't be able to fail, but if it does we'll let Sentry know
Sentry.captureException(error);
if (!didCancel(error)) {
// this task shouldn't be able to fail, but if it does we'll let Sentry know
Sentry.captureException(error);
}
});

yield promise;
Expand Down