services/progress: Add missing didCancel() check
#3159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `updateTask` uses the `.drop()` modifier, which means it cancels automatically if there is already a running instance. This cancellation causes a `TaskCancelation` error rejection on the `perform()` call, and we should ignore that kind of error instead of reporting it to Sentry.
|
Whoops @bors r+ |
|
📌 Commit 779c34b has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updateTaskuses the.drop()modifier, which means it cancels automatically if there is already a running instance. This cancellation causes aTaskCancelationerror rejection on theperform()call, and we should ignore that kind of error instead of reporting it to Sentry.Resolves #3157
r? @pichfl