Skip to content

Conversation

gshotwell
Copy link
Contributor

@gshotwell gshotwell commented Oct 3, 2023

This reopens an old pr which had gotten into a rather gnarly git state, and I thought it was easier to just create a new branch.

The comments from the prior PR which were unresolved were:

  • Should we come up with an alternative to htmlwidgets::HTML() for passing Javascript options to selectize (Done in Add JS class py-htmltools#81)
  • The R code handles a few more things with selectize options, should we copy that behaviour?
  • Do we need a test like this one to confirm that plugins can be added.

Fixes #914
Fixes #158

@gshotwell gshotwell requested a review from jcheng5 January 14, 2024 17:33
Gordon Shotwell added 2 commits January 15, 2024 12:42
Copy link
Collaborator

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the JS class moving from htmltools to shiny, and the other comments I made, LGTM.

@gshotwell gshotwell merged commit 9f0e753 into main Jan 22, 2024
@gshotwell gshotwell deleted the selectize-options-2 branch January 22, 2024 17:11
@SamEdwardes
Copy link

Awesome! This is going to make one of my shiny apps much easier to maintain :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic creation of selectize choices input_selectize()/update_selectize() should allow for custom selectize.js options
6 participants