-
Notifications
You must be signed in to change notification settings - Fork 114
feat: Pass options to input_selectize #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
reviewed
Jan 16, 2024
jcheng5
reviewed
Jan 18, 2024
jcheng5
reviewed
Jan 18, 2024
jcheng5
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the JS class moving from htmltools to shiny, and the other comments I made, LGTM.
Co-authored-by: Joe Cheng <[email protected]>
cpsievert
reviewed
Jan 19, 2024
Delete Calc folder
…hiny into selectize-options-2
Awesome! This is going to make one of my shiny apps much easier to maintain :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reopens an old pr which had gotten into a rather gnarly git state, and I thought it was easier to just create a new branch.
The comments from the prior PR which were unresolved were:
htmlwidgets::HTML()
for passing Javascript options to selectize (Done in Add JS class py-htmltools#81)Fixes #914
Fixes #158