Add JS class #81
Closed
Add JS class #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Jan 16, 2024
|
|
||
| class JS(RAW): | ||
| """ | ||
| Mark a string as raw JavaScript. |
There was a problem hiding this comment.
Suggested change
| Mark a string as raw JavaScript. | |
| Mark a string as raw JavaScript. This will prevent the string from being escaped when | |
| rendered inside an HTML tag. |
There was a problem hiding this comment.
Wait, is this not true? Now that I think about it, maybe it shouldn't be true? Or at least, JS() for the purposes of using inside tags.script() is very different than JS() for the purposes of marking certain parts of JSON-encoded options as needing to be evaluated in the client. We should not make it easy for users to mistakenly get the latter when they really just meant the former.
jcheng5
reviewed
Jan 16, 2024
|
We decided that this function was confusing in htmltools so are going to add a shiny-specific helper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a JS class which we need for passing options to HTML tools. Since this class is currently identical to
HTMLI created a parent classRAWto hold that logic. I thought it was better to haveHTMLandJSas two child classes rather than as aliases in case we want to add HTML or JS specific methods (minify maybe?) down the road.