Skip to content

chore!: Make app_opts() args into kwargs #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore!: Make app_opts() args into kwargs #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebdaf9f
Make `app_opts()` args into kwargs
schloerke Mar 10, 2025
d608363
Update app.py
schloerke Mar 10, 2025
2c1a12d
Update CHANGELOG.md
schloerke Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changes

* Express mode's `app_opts()` requires all arguments to be keyword-only. If you are using positional arguments, you will need to update your code. (#1895)

* The `.get_latest_stream_result()` method on `ui.MarkdownStream()` was deprecated in favor of the new `.latest_stream` property. Call `.result()` on the property to get the latest result, `.status` to check the status, and `.cancel()` to cancel the stream.

### Bug fixes
Expand Down
1 change: 1 addition & 0 deletions shiny/express/_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ class AppOpts(TypedDict):

@no_example()
def app_opts(
*,
static_assets: str | Path | Mapping[str, str | Path] | MISSING_TYPE = MISSING,
debug: bool | MISSING_TYPE = MISSING,
):
Expand Down
2 changes: 1 addition & 1 deletion tests/playwright/shiny/components/chat/icon/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

ui.page_opts(title="Chat Icons")

app_opts({"/img": Path(__file__).parent / "img"})
app_opts(static_assets={"/img": Path(__file__).parent / "img"})

with ui.layout_columns():
# Default Bot ---------------------------------------------------------------------
Expand Down
Loading