chore!: Make app_opts() args into kwargs
#1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR converts the parameters of app_opts() to keyword-only arguments for improved clarity and future scalability.
- Updated the call in tests to use the new keyword parameter "static_assets".
- Updated the function signature in shiny/express/_run.py to enforce keyword-only arguments.
- Added a corresponding changelog entry to inform users of the change.
Reviewed Changes
| File | Description |
|---|---|
| tests/playwright/shiny/components/chat/icon/app.py | Updated test to call app_opts() using the keyword static_assets. |
| CHANGELOG.md | Added an entry to detail the breaking change on app_opts() API. |
| shiny/express/_run.py | Modified the function signature to enforce keyword-only parameters. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
gadenbuie
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters are independent and will not scale with new additions: ex:
bookmark_store.Making them kwargs feels like a natural setup.