Skip to content

bug(download): Properly namespace output_id for render.download in modules #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2024
Merged

bug(download): Properly namespace output_id for render.download in modules #1732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
357b86e
Properly namespacing output_id for render.download in order for it to
nsiicm0 Oct 11, 2024
331d1c5
Update CHANGELOG.md
schloerke Oct 11, 2024
9ed8d58
Add comments
schloerke Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* `shiny create` now uses the template `id` rather than the directory name as the default directory. (#1666)

* `ui.Theme()` now works correctly on Windows when the theme requires Sass compilation. (thanks @yuuuxt, #1684)
* `ui.Theme()` now works correctly on Windows when the theme requires Sass compilation. (Thanks, @yuuuxt!) (#1684)

* Fixed multiple input controllers (`InputSlider`, `InputDate`, `InputDateRange`, `InputCheckbox`, and `InputCheckboxGroup`) in `shiny.playwright.controller` to check the `width` property within the `style` attribute. (#1691, #1696, #1702)

Expand All @@ -76,6 +76,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed output controller `OutputDataFrame` in `shiny.playwright.controller` to correctly assert the number of rows in `.expect_nrow()` as the total number of virtual rows, not the number of currently displaying rows. (#1719)

* Fixed issue where `@render.download` did not respect the module namespacing. (Thanks, @nsiicm0) (#1732)

## [1.1.0] - 2024-09-03

Expand Down
7 changes: 5 additions & 2 deletions shiny/render/_render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,8 @@ def url() -> str:
from urllib.parse import quote

session = require_active_session(None)
return f"session/{quote(session.id)}/download/{quote(self.output_id)}?w="
# All download urls must be fully namespaced
return f"session/{quote(session.id)}/download/{quote(session.ns(self.output_id))}?w="

# Unlike most value functions, this one's name is `url`. But we want to get the
# name from the user-supplied function.
Expand All @@ -705,7 +706,9 @@ def url() -> str:
# have been started.
session = get_current_session()
if session is not None and not session.is_stub_session():
session._downloads[self.output_id] = DownloadInfo(
# All download objects are stored in the root session.
# They must be fully namespaced
session._downloads[session.ns(self.output_id)] = DownloadInfo(
filename=self.filename,
content_type=self.media_type,
handler=fn,
Expand Down
Loading