bug(download): Properly namespace output_id for render.download in modules #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Oct 11, 2024
schloerke
approved these changes
Oct 11, 2024
schloerke
changed the title
schloerke
changed the title
|
Thank you @nsiicm0 !! |
|
The render.image also has similar issue. I cannot loop one render.image function and takes in multiple ids. Could you also help look into that? Thanks! @schloerke |
|
@michaelsong-vbu I do not readily see the issue. Do you mind opening a new issue with a shinkylive.io reprex (reproducible example)? Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724