Skip to content

fix(shiny create): Use template.id for default directory #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix(shiny create): Use template.id for default directory #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db31b26
fix(shiny create): Use `template.id` for default directory
gadenbuie Sep 4, 2024
71d3d28
docs: Add changelog item
gadenbuie Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to Shiny for Python will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [UNRELEASED]

### Bug fixes

* `shiny create` now uses the template `id` rather than the directory name as the default directory. (#1666)

## [1.1.0] - 2024-09-03

### New features
Expand Down
3 changes: 1 addition & 2 deletions shiny/_main_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,6 @@ def app_template_questions(
mode: Optional[str] = None,
dest_dir: Optional[Path] = None,
):
template_dir = template.path
template_cli_name = cli_bold(cli_field(template.title or template.id))

if mode == "express" and not template.express_available:
Expand All @@ -666,7 +665,7 @@ def app_template_questions(
)

click.echo(cli_wait(f"Creating {template_cli_name} Shiny app..."))
dest_dir = directory_prompt(dest_dir, template_dir.name)
dest_dir = directory_prompt(dest_dir, template.id)

if mode is None and template.express_available:
mode = questionary.select(
Expand Down
Loading