fix(shiny create): Use template.id for default directory
#1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
approved these changes
Sep 5, 2024
schloerke
added a commit
that referenced
this pull request
Sep 5, 2024
* main: fix(shiny create): Use `template.id` for default directory (#1666)
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Sep 5, 2024
* main: chore: Fix white space formatting in `reactive.poll` Returns (posit-dev#1667) fix(shiny create): Use `template.id` for default directory (posit-dev#1666) fix(tests): Add missing env vars for shinyapps.io tests (posit-dev#1663) v1.1.0 release candidate Put streaming visual cue at the end of the content (posit-dev#1659) CI(debug): Print full stdout/stderr when command fails (posit-dev#1660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use the template's directory name, we should be using the
template.idfor the default directory inshiny create.Before
After