setup.cfg -> pyproject.toml #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
force-pushed
the
pyproject.toml
branch
from
6903331 to
1c92599
Compare
|
@wch @schloerke can either of you think of any downstream problems from shiny having version numbers that look like |
|
Projects:
I may have missed something and would like @wch to add his stamp of approval. But I have confidence so far! If we do need it on the packaging side, we can leverage To remind myself... Unlike R where versions go from |
|
TODO: Check if additional (unwanted) files are included in the sdist package bundle due to using setuptools_scm |
machow
reviewed
Aug 22, 2024
machow
reviewed
Aug 22, 2024
jcheng5
force-pushed
the
pyproject.toml
branch
2 times, most recently
from
38916ca to
0f21df9
Compare
This is necessary for setuptools_scm to work correctly in CI environments.
Since pyproject.toml tells black what Python versions are supported, it's slightly stricter than the default (see https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version).
These are handled automatically by setuptools_scm now
jcheng5
force-pushed
the
pyproject.toml
branch
from
0f21df9 to
1f801f4
Compare
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Sep 5, 2024
* main: setup.cfg -> pyproject.toml (posit-dev#1625) docs(navset): Add server function to navset docs (posit-dev#1596) Pin syrupy to avoid pytest-rerunfailures incompatibility (posit-dev#1632) refactor: `shiny create` and `shiny add test` supporting functions (posit-dev#1629) Update CHANGELOG.md Fix posit-dev#1601: Force text/javascript for .js files Work around griffe 1.0 breaking changes feat(shiny create): Support simpler syntax for `--github` flag (posit-dev#1623) Make sure `Chat.messages(format='google')` converts role assistant -> model (posit-dev#1622) Fix `NormalizerRegistry.register()` (posit-dev#1619) Update JS/CSS from shiny and bslib (posit-dev#1617) Add ability to update `Chat()`'s input placeholder (posit-dev#1594) docs: Add double-quotes to shiny[theme] (posit-dev#1605) `json.dump()` each websocket message once instead of twice (posit-dev#1597) docs: Update note on style keys allowing for kebab-case (posit-dev#1595) docs: fix navset function links (posit-dev#1590) Get `ui.Chat()` working inside Shiny modules (posit-dev#1582) bug(notification): Allow for duration to be `None` and passed to client (posit-dev#1577) Fix logic for detection of support files in docs (posit-dev#1580) docs(navset): Add examples for navset (posit-dev#1579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds properly, but it doesn't quite work on local builds; requests for
shiny.jsresult in 404. I think it may have to do with the+character that setuptools_scm puts into the version string, e.g.1.0.1.dev21+g4d7a2e5e.d20240821.