Skip to content

Make sure Chat.messages(format='google') converts role assistant -> model #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2024
Merged

Make sure Chat.messages(format='google') converts role assistant -> model #1622

merged 2 commits into from
Aug 20, 2024

Conversation

cpsievert
Copy link
Collaborator

Closes #1620

@cpsievert cpsievert merged commit c97f09b into main Aug 20, 2024
46 of 47 checks passed
@cpsievert cpsievert deleted the fix/gemini-message-type branch August 20, 2024 21:23
@cpsievert cpsievert mentioned this pull request Aug 20, 2024
Closed
schloerke added a commit that referenced this pull request Aug 22, 2024
@schloerke
Merge branch 'main' into add-server-func-for-navset
6394136 
* main:
  refactor: `shiny create` and `shiny add test` supporting functions (#1629)
  Update CHANGELOG.md
  Fix #1601: Force text/javascript for .js files
  Work around griffe 1.0 breaking changes
  feat(shiny create): Support simpler syntax for `--github` flag (#1623)
  Make sure `Chat.messages(format='google')` converts role assistant -> model (#1622)
  Fix `NormalizerRegistry.register()` (#1619)
  Update JS/CSS from shiny and bslib (#1617)
  Add ability to update `Chat()`'s input placeholder (#1594)
  docs: Add double-quotes to shiny[theme] (#1605)
  `json.dump()` each websocket message once instead of twice (#1597)
schloerke added a commit to machow/py-shiny that referenced this pull request Sep 5, 2024
@schloerke
Merge branch 'main' into machow-feat-narwhals
f11769f 
* main:
  setup.cfg -> pyproject.toml (posit-dev#1625)
  docs(navset): Add server function to navset docs (posit-dev#1596)
  Pin syrupy to avoid pytest-rerunfailures incompatibility (posit-dev#1632)
  refactor: `shiny create` and `shiny add test` supporting functions (posit-dev#1629)
  Update CHANGELOG.md
  Fix posit-dev#1601: Force text/javascript for .js files
  Work around griffe 1.0 breaking changes
  feat(shiny create): Support simpler syntax for `--github` flag (posit-dev#1623)
  Make sure `Chat.messages(format='google')` converts role assistant -> model (posit-dev#1622)
  Fix `NormalizerRegistry.register()` (posit-dev#1619)
  Update JS/CSS from shiny and bslib (posit-dev#1617)
  Add ability to update `Chat()`'s input placeholder (posit-dev#1594)
  docs: Add double-quotes to shiny[theme] (posit-dev#1605)
  `json.dump()` each websocket message once instead of twice (posit-dev#1597)
  docs: Update note on style keys allowing for kebab-case (posit-dev#1595)
  docs: fix navset function links (posit-dev#1590)
  Get `ui.Chat()` working inside Shiny modules (posit-dev#1582)
  bug(notification): Allow for duration to be `None` and passed to client (posit-dev#1577)
  Fix logic for detection of support files in docs (posit-dev#1580)
  docs(navset): Add examples for navset (posit-dev#1579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shiny Chat with Gemini - "Error in Effect: 400 Please use a valid role: user, model"
1 participant
@cpsievert