Skip to content

fix(bootstrap): Include all files #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix(bootstrap): Include all files #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0355be
fix(bootstrap): Include all files
gadenbuie Apr 29, 2024
d0ca857
docs: Add item to changelog
gadenbuie Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug fixes

* Fixed an issue that prevented Shiny from serving the `font.css` file referenced in Shiny's Bootstrap CSS file. (#1342)

### Other changes

* `Session` is now an abstract base class, and `AppSession` is a concrete subclass of it. Also, `ExpressMockSession` has been renamed `ExpressStubSession` and is a concrete subclass of `Session`. (#1331)
Expand Down
1 change: 1 addition & 0 deletions shiny/ui/_html_deps_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def bootstrap_deps(include_css: bool = True) -> list[HTMLDependency]:
script={"src": "bootstrap.bundle.min.js"},
stylesheet={"href": "bootstrap.min.css"} if include_css else None,
meta={"name": "viewport", "content": "width=device-width, initial-scale=1"},
all_files=True,
)
deps = [jquery_deps(), dep]
return deps
Expand Down