Skip to content

Conversation

gadenbuie
Copy link
Collaborator

Adds all_files=True to the Bootstrap dependency so that the font files in the base Bootstrap theme are correctly included in the dependency. Without this, font.css and the font files aren't available in the browser but show up in bootstrap.min.css.

Noticed in posit-dev/py-shiny-site#140.

@gadenbuie gadenbuie marked this pull request as ready for review April 29, 2024 18:12
@gadenbuie gadenbuie requested review from jcheng5 and cpsievert April 29, 2024 19:34
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this wasn't needed to get 200s for font.css and font/ files in a standard app. I'm guessing that's cause the files don't need to be copied anywhere?

(PS. I will admit, I'm not thrilled the default for all_files is different in Python vs R).

@gadenbuie gadenbuie added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit f732222 Apr 30, 2024
@gadenbuie gadenbuie deleted the fix/bootstrap-all-files branch April 30, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants