[WIN] Set binaries details #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR is intended to set binary details for the OpenVINO Tokenizers project on Windows by introducing version resource configuration and updating the build scripts.
- Added a new CMake module (cmake/vs_version.cmake) to generate a Windows version resource file.
- Introduced a corresponding template (cmake/templates/vs_version.rc.in) for version resource configuration.
- Updated the main CMakeLists.txt to include the new version resource module.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmake/vs_version.cmake | Adds definitions for project binary details and a function to add the Windows version resource. |
| cmake/templates/vs_version.rc.in | Provides the template for the version resource with relevant placeholders. |
| CMakeLists.txt | Includes the new version resource CMake module to integrate binary details. |
Comments suppressed due to low confidence (1)
cmake/templates/vs_version.rc.in:21
- The variable PROJECT_DESCRIPTION used for the FileDescription is not defined in the CMake module. Consider adding a definition for PROJECT_DESCRIPTION in 'cmake/vs_version.cmake' or removing its usage from the resource file to avoid unexpected placeholder output.
VALUE "FileDescription", "@PROJECT_DESCRIPTION@\0"
apaniukov
approved these changes
Jul 9, 2025
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Jul 25, 2025
https://jira.devtools.intel.com/browse/CVS-169011 The same fix in tokenizers - openvinotoolkit/openvino_tokenizers#502 --------- Co-authored-by: Vladimir Zlobin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.devtools.intel.com/browse/CVS-168487