Skip to content

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Jul 15, 2025

@Wovchena Wovchena requested a review from Copilot July 16, 2025 10:03
@Wovchena Wovchena enabled auto-merge July 16, 2025 10:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds Windows version-resource support to shared libraries by defining a CMake helper and invoking it in C and C++ builds.

  • Introduces add_vs_version_resource to generate and attach .rc version-info files.
  • Updates src/cpp/CMakeLists.txt and src/c/CMakeLists.txt to call this helper for WIN32 targets.
  • Adds the helper (cmake/vs_version.cmake), its template (cmake/templates/vs_version.rc.in), and includes the helper in the top-level CMakeLists.txt.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/cpp/CMakeLists.txt Calls add_vs_version_resource for the C++ shared library on Windows
src/c/CMakeLists.txt Calls add_vs_version_resource for the C shared library on Windows
cmake/vs_version.cmake Defines the add_vs_version_resource function
cmake/templates/vs_version.rc.in Template for generating Windows version-resource info
CMakeLists.txt Includes the vs_version.cmake helper in the root build
Comments suppressed due to low confidence (1)

src/cpp/CMakeLists.txt:173

  • Consider adding a CI or integration check on Windows to verify that add_vs_version_resource runs correctly and the version resource is embedded as expected.
if(WIN32)

@Wovchena Wovchena disabled auto-merge July 16, 2025 10:08
@Wovchena Wovchena enabled auto-merge July 16, 2025 16:24
@github-actions github-actions bot added the category: GHA CI based on Github actions label Jul 17, 2025
@Wovchena Wovchena added this pull request to the merge queue Jul 25, 2025
Merged via the queue into openvinotoolkit:master with commit 42d7f33 Jul 25, 2025
97 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: C API category: cmake / build Cmake scripts category: GHA CI based on Github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants