-
Notifications
You must be signed in to change notification settings - Fork 284
[WIN] Set binaries details #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wovchena
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Windows version-resource support to shared libraries by defining a CMake helper and invoking it in C and C++ builds.
- Introduces
add_vs_version_resource
to generate and attach.rc
version-info files. - Updates
src/cpp/CMakeLists.txt
andsrc/c/CMakeLists.txt
to call this helper for WIN32 targets. - Adds the helper (
cmake/vs_version.cmake
), its template (cmake/templates/vs_version.rc.in
), and includes the helper in the top-levelCMakeLists.txt
.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/cpp/CMakeLists.txt | Calls add_vs_version_resource for the C++ shared library on Windows |
src/c/CMakeLists.txt | Calls add_vs_version_resource for the C shared library on Windows |
cmake/vs_version.cmake | Defines the add_vs_version_resource function |
cmake/templates/vs_version.rc.in | Template for generating Windows version-resource info |
CMakeLists.txt | Includes the vs_version.cmake helper in the root build |
Comments suppressed due to low confidence (1)
src/cpp/CMakeLists.txt:173
- Consider adding a CI or integration check on Windows to verify that
add_vs_version_resource
runs correctly and the version resource is embedded as expected.
if(WIN32)
Merged
via the queue into
openvinotoolkit:master
with commit Jul 25, 2025
42d7f33
97 of 101 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.devtools.intel.com/browse/CVS-169011
The same fix in tokenizers - openvinotoolkit/openvino_tokenizers#502