Skip to content

8368989: Use NMethodMarkingScope and ThreadsClaimTokenScope in shenandoahSTWMark #27589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+7 −4
Closed

8368989: Use NMethodMarkingScope and ThreadsClaimTokenScope in shenandoahSTWMark #27589

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d2e4a5
replace
fandreuz Oct 1, 2025
442bc5b
trigger
fandreuz Oct 1, 2025
0801a49
trigger
fandreuz Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/hotspot/share/gc/shenandoah/shenandoahSTWMark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
*/



#include "gc/shared/strongRootsScope.hpp"
#include "code/nmethod.hpp"
#include "gc/shared/taskTerminator.hpp"
#include "gc/shared/workerThread.hpp"
#include "gc/shenandoah/shenandoahClosures.inline.hpp"
Expand All @@ -36,10 +35,13 @@
#include "gc/shenandoah/shenandoahRootProcessor.inline.hpp"
#include "gc/shenandoah/shenandoahSTWMark.hpp"
#include "gc/shenandoah/shenandoahVerifier.hpp"
#include "runtime/threads.hpp"

class ShenandoahSTWMarkTask : public WorkerTask {
private:
ShenandoahSTWMark* const _mark;
NMethodMarkingScope _nmethod_marking_scope;
ThreadsClaimTokenScope _threads_claim_token_scope;

public:
ShenandoahSTWMarkTask(ShenandoahSTWMark* mark);
Expand All @@ -48,7 +50,9 @@ class ShenandoahSTWMarkTask : public WorkerTask {

ShenandoahSTWMarkTask::ShenandoahSTWMarkTask(ShenandoahSTWMark* mark) :
WorkerTask("Shenandoah STW mark"),
_mark(mark) {
_mark(mark),
_nmethod_marking_scope(),
_threads_claim_token_scope() {
}

void ShenandoahSTWMarkTask::work(uint worker_id) {
Expand Down Expand Up @@ -98,7 +102,6 @@ void ShenandoahSTWMark::mark() {
_generation->scan_remembered_set(false /* is_concurrent */);
}

StrongRootsScope scope(nworkers);
ShenandoahSTWMarkTask task(this);
heap->workers()->run_task(&task);

Expand Down