8368989: Use NMethodMarkingScope and ThreadsClaimTokenScope in shenandoahSTWMark

[fandreuz]

Replace StrongRootsScope with ThreadsClaimTokenScope in shenandoahSTWMark to be more precise with what is needed and why.

• ShenandoahSTWMark uses MarkingNMethodClosure, so we also need NMethodMarkingScope.
• nworkers is guaranteed to be > 0

Passes tier1 and tier2 (fastdebug).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368989: Use NMethodMarkingScope and ThreadsClaimTokenScope in shenandoahSTWMark (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27589/head:pull/27589
$ git checkout pull/27589

Update a local copy of the PR:
$ git checkout pull/27589
$ git pull https://git.openjdk.org/jdk.git pull/27589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27589

View PR using the GUI difftool:
$ git pr show -t 27589

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27589.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368989: Use NMethodMarkingScope and ThreadsClaimTokenScope in shenandoahSTWMark

Reviewed-by: shade, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 8be1616: 8367609: serviceability/sa/ClhsdbPmap.java fails when built with Clang
• dfd3832: 8368966: Remove spurious VMStructs friends
• 5251405: 8368848: JShell's code completion not always working for multi-snippet inputs
• ... and 19 more: https://git.openjdk.org/jdk/compare/9b02896b4725ef932a23be11ff76ce04bda0d652...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0801a496)
• 00: Full (442bc5be)

[fandreuz]

Thanks for the review @albertnetymk and @shipilev.

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 442bc5b) is now ready to be sponsored by a Committer.

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 0801a49) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 1d55ade.
Since your change was applied there have been 30 commits pushed to the master branch:

• 3d113af: 8369051: More small Float16 refactorings
• 5fccabf: 8368670: Deadlock in JFR on event register + class load
• 1a03a1f: 8369033: Remove dead code in training data
• ... and 27 more: https://git.openjdk.org/jdk/compare/9b02896b4725ef932a23be11ff76ce04bda0d652...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @fandreuz Pushed as commit 1d55ade.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.