[chore] Remove notes from rpc base

[thompson-tomo]

Changes

Remove notes from rpc.service/method attribute as they only apply to the rpc spans as discussed in #2736 as such they have been added to the span allowing them to be removed from metrics.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• Change log entry added, according to the guidelines in When to add a changelog entry.
  • If your PR does not need a change log, start the PR title with [chore]
• Links to the prototypes or existing instrumentations (when adding or changing conventions)

[trask]

Remove notes from rpc.service/method attribute as they only apply to the rpc spans as discussed in #2503 as such they have been added to the span allowing them to be removed from metrics.

I didn't follow the context, can you link to where this was discussed in 2503, and explain more how this affects metrics? thanks

[thompson-tomo]

My apologies I referred to the wrong PR, it was meant to be #2736. Please see #2736 (comment)

The issue is the attribute notes are only applicable to rpc spans. This is why they are now on the span and now this enables it to come off the base which allows the aws attributes to also not have the notes as they are not correct.