explicit json rpc span definitions #2228 #2503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompson-tomo
changed the title
jsuereth
added
the
experts needed
|
We should hold on RPC related changes until the RPC semconv SIG is formed. |
|
As this came about due to a bug, what can be done to progress it? Would changing the rpc.method conditionally required message to indicate only for json-rpc & put back rpc.service allow this to be progressed sooner? |
thompson-tomo
force-pushed
the
fix/#2228_MethodRequirement
branch
from
a5929bf to
cc53736
Compare
thompson-tomo
changed the title
trask
reviewed
Sep 11, 2025
lmolkova
reviewed
Sep 11, 2025
lmolkova
reviewed
Sep 11, 2025
trask
approved these changes
Sep 18, 2025
Co-authored-by: Trask Stalnaker <[email protected]>
thompson-tomo
force-pushed
the
fix/#2228_MethodRequirement
branch
from
6700eae to
2b6e560
Compare
|
@lmolkova could you take a look at this & let me know if everything is resolved and can hopefully be merged soon. |
This was referenced Sep 22, 2025
thompson-tomo
force-pushed
the
fix/#2228_MethodRequirement
branch
from
3005d80 to
ab4d859
Compare
This was referenced Sep 23, 2025
lmolkova
approved these changes
Sep 24, 2025
github-project-automation
bot
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
trask
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
Merged
via the queue into
open-telemetry:main
with commit Sep 25, 2025
b5d47c9
17 of 18 checks passed
github-project-automation
bot
moved this from In Progress
to Done
in RPC Semantic Conventions Stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2228
Closes #2762
Changes
This rewrites the jsonrpc page to provide the span definitions rather than just listing the attributes as requested in #2720
This also defines jsonrpc as a system which had been documented but wasn't part of the model.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]