feat: add DEF_SOURCE_LINE to enable "Go to test" #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonsoftware
force-pushed
the
feature/add-def-source-line
branch
from
107868f to
98d4997
Compare
|
Hi @rjaegers , I had to rebase the branch to the latest commits in order to have valid tests, hope it is not a problem. So will you ping here when microsoft/vscode-cmake-tools#4321 will be merged ? Have a nice day. |
|
@neonsoftware sure, no problem at all. Thanks for the help fixing the ci, and for the initial project. I had the same idea to get the bats tests of my devcontainer in the Test Explorer. Then I found out that you already created this! In principle it would be fine to merge this PR already. The property on the tests won't hurt, and when microsoft/vscode-cmake-tools#4321 is merged it will start working. I have tested with a patched extension, and it works great. |
|
@rjaegers Ok, if that is the case the line can go in and wait. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a "richer" test experience by adding the DEF_SOURCE_LINE property on all tests. This property is filled with the source:line of each test and enables "Go to test" from the test explorer and adds test-icons in the gutter for the test files.
Please note that this will not work until my PR microsoft/vscode-cmake-tools#4321 is merged.