fix(ctest): don't require backtrace in presence of DEF_SOURCE_LINE #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjaegers
changed the title
rjaegers
changed the title
|
@microsoft-github-policy-service agree company="Philips" |
gcampbell-msft
requested changes
Mar 7, 2025
|
@gcampbell-msft added a CHANGELOG entry, hope I am in the right ballpark with the wording. I have a follow-up PR ready that adds name-demangling for C++ symbols. |
gcampbell-msft
previously approved these changes
Mar 10, 2025
|
Just a merge conflict resolution in CHANGELOG.md. Merging. |
hippo91
pushed a commit
to hippo91/vscode-cmake-tools
that referenced
this pull request
Mar 29, 2025
…icrosoft#4321) * ctest: Don't require backtrace in presence of DEF_SOURCE_LINE * docs: add CHANGELOG entry --------- Co-authored-by: Garrett Campbell <[email protected]>
fajkomix1990
pushed a commit
to fajkomix1990/mati---glowny
that referenced
this pull request
Jul 2, 2025
…icrosoft#4321) * ctest: Don't require backtrace in presence of DEF_SOURCE_LINE * docs: add CHANGELOG entry --------- Co-authored-by: Garrett Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes visible behavior
The following changes are proposed:
The purpose of this change
When using the DEF_SOURCE_LINE property on a test it is now required to have backtrace information present, while that backtrace information is not used. This change removes that dependency to enable support for
gtest_discover_testsvia the XML/JSON output. This will require an additional PR on the GoogleTest module in CMake.Other Notes/Information
Based on the great work done in #3631.