Skip to content

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Sep 23, 2025

Summary

The helm chart linting functionality is added as part on lint_repo task eventually called our precommit script. Apart from the lint_repo task, precommit script also gets called from the evg task evg/run_pre_commit. And when it's run via evg/run_pre_commit it's failing, because ct is not found. We forgot to update the evg/run_pre_commit task to setup ct because it's doesn't get run in PR patches.
Since this task (evg/run_pre_commit) doesn't get executed as part of PR patches, we didn't face this problem in PR patches. But we got to know about it from a PR that dependabot raises.
In PR patches the task evg/run_pre_commit gets run but the precommit script doesn't actually get executed because it's requires the branch name to be in specific format.

Proof of Work

Successful CI in this PR.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.4.1 Release Notes

@viveksinghggits viveksinghggits added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Sep 23, 2025
@viveksinghggits viveksinghggits changed the title Fix chart linting issue in `evg/run_pre_commit" Fix chart linting issue in evg/run_pre_commit task Sep 23, 2025
@viveksinghggits viveksinghggits merged commit 666cdf3 into master Sep 23, 2025
37 of 38 checks passed
@viveksinghggits viveksinghggits deleted the runprecommitfix_version_bump branch September 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants