Fix chart linting issue in evg/run_pre_commit
task
#470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The helm chart linting functionality is added as part on
lint_repo
task eventually called our precommit script. Apart from the lint_repo task, precommit script also gets called from the evg taskevg/run_pre_commit
. And when it's run viaevg/run_pre_commit
it's failing, becausect
is not found. We forgot to update theevg/run_pre_commit
task to setupct
because it's doesn't get run in PR patches.Since this task (
evg/run_pre_commit
) doesn't get executed as part of PR patches, we didn't face this problem in PR patches. But we got to know about it from a PR that dependabot raises.In PR patches the task
evg/run_pre_commit
gets run but the precommit script doesn't actually get executed because it's requires the branch name to be in specific format.Proof of Work
Successful CI in this PR.
_version_bump
, that is expected byrun_pre_commit
. https://github.com/mongodb/mongodb-kubernetes/blob/master/scripts/evergreen/precommit_bump.sh#L18Checklist
skip-changelog
label if not needed