You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix chart linting issue in evg/run_pre_commit task (#470)
# Summary
The helm chart linting functionality is added as part on `lint_repo`
task eventually called our precommit script. Apart from the lint_repo
task, precommit script also gets called from the evg task
`evg/run_pre_commit`. And when it's run via `evg/run_pre_commit` it's
failing, because `ct` is not found. We forgot to update the
`evg/run_pre_commit` task to setup `ct` because it's doesn't get run in
PR patches.
Since this task (`evg/run_pre_commit`) doesn't get executed as part of
PR patches, we didn't face this problem in PR patches. But we got to
know about it from [a
PR](#468) that
dependabot raises.
In PR patches the task `evg/run_pre_commit` gets run but the precommit
script doesn't actually get executed because it's requires the branch
name to be in [specific
format](https://github.com/mongodb/mongodb-kubernetes/blob/master/scripts/evergreen/precommit_bump.sh#L18).
## Proof of Work
Successful CI in this PR.
- Make sure lint_repo passes
- Make sure run_pre_commit passes and it actually calls precommit,
because this PR branch is named in the format `_version_bump`, that is
expected by `run_pre_commit`.
https://github.com/mongodb/mongodb-kubernetes/blob/master/scripts/evergreen/precommit_bump.sh#L18
## Checklist
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [x] Have you checked whether your jira ticket required DOCSP changes?
- [x] Have you added changelog file?
- use `skip-changelog` label if not needed
- refer to [Changelog files and Release
Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes)
section in CONTRIBUTING.md for more details
0 commit comments