Skip to content

<stack>, <queue>: Add std::forward for append_range #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

<stack>, <queue>: Add std::forward for append_range #5168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2a832
Use std::forward in append_range
hewillk Dec 6, 2024
ca4418e
Use std::forward for append_range
hewillk Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stl/inc/queue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ public:
#if _HAS_CXX23
template <_Container_compatible_range<_Ty> _Rng>
void push_range(_Rng&& _Range) {
if constexpr (requires { c.append_range(_Range); }) {
c.append_range(_Range);
if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
c.append_range(_STD forward<_Rng>(_Range));
} else {
_RANGES copy(_Range, back_insert_iterator{c});
}
Expand Down Expand Up @@ -394,8 +394,8 @@ public:
void push_range(_Rng&& _Range) {
const size_type _Old_size = c.size();

if constexpr (requires { c.append_range(_Range); }) {
c.append_range(_Range);
if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
c.append_range(_STD forward<_Rng>(_Range));
} else {
_RANGES copy(_Range, back_insert_iterator{c});
}
Expand Down
4 changes: 2 additions & 2 deletions stl/inc/stack
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ public:
#if _HAS_CXX23
template <_Container_compatible_range<_Ty> _Rng>
void push_range(_Rng&& _Range) {
if constexpr (requires { c.append_range(_Range); }) {
c.append_range(_Range);
if constexpr (requires { c.append_range(_STD forward<_Rng>(_Range)); }) {
c.append_range(_STD forward<_Rng>(_Range));
} else {
_RANGES copy(_Range, back_insert_iterator{c});
}
Expand Down