Skip to content

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Dec 6, 2024

The standard requires checking that c.append_range(std​::​forward<R>(rg)) is well-formed, so this fix pedantically conforms to the standard.
Although it doesn't make sense for some containers' append_range to only accept the rvalue range, there's nothing wrong with being completely consistent with the standard.

@hewillk hewillk requested a review from a team as a code owner December 6, 2024 16:24
@CaseyCarter CaseyCarter added bug Something isn't working ranges C++20/23 ranges labels Dec 7, 2024
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Dec 7, 2024

How weird that the CLA bot decided - after 10 hours - that this PR needs CLA. I'm happy to merge as is once we get CLA cleared up.

@hewillk
Copy link
Contributor Author

hewillk commented Dec 7, 2024

@hewillk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@StephanTLavavej StephanTLavavej self-assigned this Dec 12, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 1a31980 into microsoft:main Dec 13, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Forward the Foundation! 🛸 🧑‍🔬 🪄

@hewillk hewillk deleted the main-append_range branch December 13, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ranges C++20/23 ranges
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants