Skip to content

Conversation

jamessa
Copy link
Contributor

@jamessa jamessa commented Sep 24, 2025

Fixes #57147

Previous attempt #56677 was a partial solution and caused side effects #57147 .

Proposing way of dealing with pending attributes in schedule group properly. The main principles are

  1. Keep group stack unchanged by using copy.
  2. In side a group, pending attributes are stored in $this->attributes

The flow

when entering a group, copy current pending attributes into group stack
    while in the group, store new pending attributes in $this->attributes
    on merge,
        apply group attributes first, 
        then pending attributes
on leaving a group, pop current group attributes

@taylorotwell taylorotwell merged commit f8d18a9 into laravel:12.x Sep 24, 2025
62 of 63 checks passed
tegos pushed a commit to tegos/laravel-framework that referenced this pull request Sep 28, 2025
* use copy instead of reference

* style fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify schedule group pending attributes behavior
2 participants