Clarify schedule group pending attributes behavior

[jamessa]

Laravel Version

Since 12.25.0

PHP Version

8.4

Description

Using pending attribute in schedule group doesn't work as expected.

If I remove clone from #56677, both test cases passes.

But in 12.25, second test case failed.

Should I always start with command to create an Event object in schedule group? or pending attributes are expected in group?

Steps To Reproduce

test('command before at', function () {
    $schedule = new ScheduleClass;

    $schedule->weekdays()
        ->group(function (ScheduleClass $schedule) {
            $schedule->command('inspire')->at('01:00');
        });

    $events = $schedule->events();
    $this->assertSame('0 1 * * 1-5', $events[0]->expression); // this works.
});


test('at before command', function () {
    $schedule = new ScheduleClass;

    $schedule->weekdays()
        ->group(function (ScheduleClass $schedule) {
            $schedule->at('01:00')->command('inspire');
        });

    $events = $schedule->events();
    $this->assertSame('0 1 * * 1-5', $events[0]->expression);
// in 12.25 it becomes * * * * 1-5 and fails
});

[jamessa]

In https://github.com/laravel/framework/blob/12.x/src/Illuminate/Console/Scheduling/Schedule.php#L479

 if (method_exists(PendingEventAttributes::class, $method)) {
            $this->attributes ??= array_last($this->groupStack) ?: new PendingEventAttributes($this);

            return $this->attributes->$method(...$parameters);
        }

new pending attributes will change last group stack. Is this expected?

[jamessa]

Here is my use case. I like to start with at to have an organized view.

Schedule::daily()
    ->runInBackground()
    ->onOneServer()
    ->group(function () {
        Schedule::at('01:00')->command('task1');
        Schedule::at('02:00')->command('telescope:prune --hours=168');
        Schedule::at('03:00')->command('task2');
        Schedule::at('04:00')->command('task3');
        Schedule::at('09:00')->command('task4'); 
        Schedule::at('09:30')->command('task5');
    });