Skip to content

chore(cloudflare): rename zoneService fields #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

chore(cloudflare): rename zoneService fields #5761

merged 1 commit into from
Aug 24, 2025

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Aug 21, 2025

What does it do ?

Rename zoneService struct fields:

  • service -> serviceV0
  • serviceV4 -> service

Motivation

#5734 renamed imports names to have the legacy api to cloudflarev0 and the new one as cloudflare.
This PR do the same with zoneService fields.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the provider Issues or PRs related to a provider label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs August 21, 2025 23:46
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 21, 2025
@mloiseleur
Copy link
Collaborator

Hello @vflaux ,

Thanks for this PR. Do you think you can connect on kubernetes slack ?

@mloiseleur
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025
@ivankatliarchuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2025
@szuecs
Copy link
Contributor

szuecs commented Aug 24, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 81290c0 into kubernetes-sigs:master Aug 24, 2025
18 checks passed
@vflaux vflaux deleted the cloudflare_migration_0 branch August 24, 2025 14:07
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Aug 28, 2025
@ivankatliarchuk
Merge branch 'master' into feat-default-ttl
c9e26ed 
* master:
  fix(doc): typo in compatibility table (kubernetes-sigs#5769)
  fix(controller): panic in events.Controller.Add() (kubernetes-sigs#5766)
  chore(cloudflare): rename zoneService fields (kubernetes-sigs#5761)
  chore(deps): bump the dev-dependencies group with 9 updates (kubernetes-sigs#5763)
  fix(http): concurrent map read/write (kubernetes-sigs#5753)
  chore(deps): bump the dev-dependencies group across 1 directory with 10 updates (kubernetes-sigs#5760)
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
@vflaux @troll-os
chore(cloudflare): rename zoneService fields (kubernetes-sigs#5761)
9304a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankatliarchuk ivankatliarchuk Awaiting requested review from ivankatliarchuk

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@ivankatliarchuk ivankatliarchuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider Issues or PRs related to a provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vflaux @k8s-ci-robot @mloiseleur @ivankatliarchuk @szuecs