Skip to content

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Aug 19, 2025

What does it do ?

Screenshot 2025-08-19 at 10 34 33

Current state is captured, just in case
Screenshot 2025-08-19 at 10 20 13

and with the fix (no major difference in terms of performance)

goos: darwin
goarch: arm64
pkg: sigs.k8s.io/external-dns/pkg/http
cpu: Apple M3 Max
BenchmarkRoundTripper
BenchmarkRoundTripper-14    	  919482	      1282 ns/op
PASS

Motivation

Fix #5748
Relates #5717

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@ivankatliarchuk ivankatliarchuk marked this pull request as draft August 19, 2025 09:37
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added metrics Issues or PRs related to metrics provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review August 21, 2025 08:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2025
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2025
@ivankatliarchuk
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit ccebff9 into kubernetes-sigs:master Aug 21, 2025
14 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-metrics-race-condition branch August 21, 2025 11:54
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Aug 28, 2025
* master:
  fix(doc): typo in compatibility table (kubernetes-sigs#5769)
  fix(controller): panic in events.Controller.Add() (kubernetes-sigs#5766)
  chore(cloudflare): rename zoneService fields (kubernetes-sigs#5761)
  chore(deps): bump the dev-dependencies group with 9 updates (kubernetes-sigs#5763)
  fix(http): concurrent map read/write (kubernetes-sigs#5753)
  chore(deps): bump the dev-dependencies group across 1 directory with 10 updates (kubernetes-sigs#5760)
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
* fix(http): concurrent map read/write

Signed-off-by: ivan katliarchuk <[email protected]>

* fix(http): concurrent map read/write

Signed-off-by: ivan katliarchuk <[email protected]>

* fix(http): concurrent map read/write

Signed-off-by: ivan katliarchuk <[email protected]>

* fix(http): concurrent map read/write

Signed-off-by: ivan katliarchuk <[email protected]>

* fix(http): concurrent map read/write

Signed-off-by: ivan katliarchuk <[email protected]>

---------

Signed-off-by: ivan katliarchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. metrics Issues or PRs related to metrics provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: concurrent map writes
3 participants