fix(helm): update helm schema

[semnell]

Description

Add helm schema changes so liveness and readiness can be int's or strings again.

Fixes #5295

[k8s-ci-robot]

Hi @semnell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stevehipwell]

CC @ivankatliarchuk

[ivankatliarchuk]

/ok-to-test

[semnell]

The tests seem to fail with 'race detected', i don't believe this change should/could cause that?

If im mistaken please let me know and i'll check it out.

[semnell]

Running make test locally seems fine..

ok      sigs.k8s.io/external-dns/provider/aws   28.205s coverage: 85.4% of statements
ok      sigs.k8s.io/external-dns/provider/awssd 2.427s  coverage: 85.9% of statements
ok      sigs.k8s.io/external-dns/provider/azure 2.440s  coverage: 79.5% of statements
ok      sigs.k8s.io/external-dns/provider/civo  2.454s  coverage: 84.3% of statements
ok      sigs.k8s.io/external-dns/provider/cloudflare    2.042s  coverage: 80.6% of statements
ok      sigs.k8s.io/external-dns/provider/coredns       2.508s  coverage: 53.9% of statements
ok      sigs.k8s.io/external-dns/provider/digitalocean  2.142s  coverage: 81.8% of statements
ok      sigs.k8s.io/external-dns/provider/dnsimple      3.488s  coverage: 81.4% of statements
ok      sigs.k8s.io/external-dns/provider/exoscale      2.800s  coverage: 68.1% of statements
ok      sigs.k8s.io/external-dns/provider/gandi 3.335s  coverage: 83.9% of statements
ok      sigs.k8s.io/external-dns/provider/godaddy       3.447s  coverage: 61.5% of statements
ok      sigs.k8s.io/external-dns/provider/google        3.417s  coverage: 80.6% of statements
ok      sigs.k8s.io/external-dns/provider/ibmcloud      2.686s  coverage: 75.7% of statements
ok      sigs.k8s.io/external-dns/provider/inmemory      2.929s  coverage: 82.6% of statements
ok      sigs.k8s.io/external-dns/provider/linode        2.039s  coverage: 84.7% of statements
ok      sigs.k8s.io/external-dns/provider/ns1   2.852s  coverage: 81.6% of statements
ok      sigs.k8s.io/external-dns/provider/oci   3.012s  coverage: 75.9% of statements
ok      sigs.k8s.io/external-dns/provider/ovh   9.373s  coverage: 95.7% of statements
ok      sigs.k8s.io/external-dns/provider/pdns  3.109s  coverage: 65.9% of statements
ok      sigs.k8s.io/external-dns/provider/pihole        2.821s  coverage: 89.4% of statements
ok      sigs.k8s.io/external-dns/provider/plural        3.008s  coverage: 31.5% of statements
ok      sigs.k8s.io/external-dns/provider/rfc2136       3.017s  coverage: 56.5% of statements
ok      sigs.k8s.io/external-dns/provider/scaleway      3.055s  coverage: 69.6% of statements
ok      sigs.k8s.io/external-dns/provider/tencentcloud  2.980s  coverage: 84.3% of statements
        sigs.k8s.io/external-dns/provider/tencentcloud/cloudapi         coverage: 0.0% of statements
ok      sigs.k8s.io/external-dns/provider/transip       2.399s  coverage: 40.7% of statements
ok      sigs.k8s.io/external-dns/provider/ultradns      2.570s  coverage: 81.8% of statements
ok      sigs.k8s.io/external-dns/provider/webhook       2.597s  coverage: 65.9% of statements
ok      sigs.k8s.io/external-dns/provider/webhook/api   2.732s  coverage: 89.7% of statements
ok      sigs.k8s.io/external-dns/registry       2.403s  coverage: 89.9% of statements
ok      sigs.k8s.io/external-dns/source 8.533s  coverage: 76.2% of statements
42.80s user 13.43s system 148% cpu 37.787s total

[semnell]

/retest

[ivankatliarchuk]

Any chance you add a test to json schema validator here https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/tests/json-schema_test.yaml with livenessProbe and readinessProbe values set to null. The schema is going to support nulls, not a problem, the helm templates itself may panic or smth.

[semnell]

I've added some tests, im not familiar with this type of testing so i hope this is sufficient.

[semnell]

The linting issue is something i can't recreate locally:

❯ ct lint --target-branch=master --check-version-increment=false
Linting charts...

------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

[ivankatliarchuk]

The ci is still failing.

[stevehipwell]

@semnell thanks for the PR, please could you also add an entry to the chart CHANGELOG.

RE your issue and based on the existing chart it looks like the schema inline comments need to be double spaced key: value # BLA not key: value # BLA.

[stevehipwell]

/label tide/merge-method-squash

[stevehipwell]

@ivankatliarchuk do you want to add the LGTM?

/approve

[ivankatliarchuk]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment