Skip to content

Conversation

circy9
Copy link
Contributor

@circy9 circy9 commented Jul 25, 2025

Description of your changes

  • Add a new annotation to all the applied resources in member clusters to denote which CRP they come from.

Fixes #151

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Unit tests

- Add setSourcePlacementAnnotation function to apply.go to annotate
  manifests with their source placement information
- Update process.go to call setSourcePlacementAnnotation during
  manifest processing
- Add comprehensive unit tests following established testing patterns
- Update common.go with source placement annotation constant
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/controllers/workapplier/apply.go 90.32% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: provide way to identify which placement definition was responsible for a member cluster resource
2 participants